plan: Phase 8 pre-publish review-driven fixes (from v1 release preview review)#81
Merged
Conversation
Cross-pollinated, de-duplicated synthesis of the v1 release preview
review from Claude, ChatGPT, and Gemini (standard + extended thinking
modes each), covering:
§1 Codebase — has_open_opportunity post-snapshot leak, CI gap, DAG
as narrative vs causal engine, leakage probe gaps, label window,
layout doc drift
§2 Dataset data — difficulty axis is prevalence not learnability,
undocumented second leakage trap, advanced calibration hidden,
acceptance bands descriptive not realism gates
§3 Presentation — isPrivate:true Kaggle blocker, socks/laundry copy,
fabricated usability scores, stale notebook forward-refs, README
drift, HF default tier wrong
§4 Integration script — preview reads wrong sources, 6-file listing,
SSH lockfile, missing tests, deploy to production without gate
Distinct from design-phase review in docs/external_review/{gemini,chatgpt}/
which covered architecture; this round reviewed the near-final bundle
and preview site.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Integrates the 2026-05-25 three-model release preview review
(v1_release_review_synthesis.md) into the planning corpus.
.agent-plan.md
- Adds Phase 8 (4 PRs) between the last done Phase 7 item and PR 7.3
(publish):
PR 8.1 — snapshot fixes + noise clamps + column cleanup + bundle regen
PR 8.2 — difficulty-axis reframe + disclosure hardening
PR 8.3 — notebook teaching improvements
PR 8.4 — integration script + preview hardening
- Marks PR 7.3 (publish) as depending on Phase 8
docs/release/v1_release_roadmap.md
- Phase summary table: marks phases 1-6 done, Phase 7 in-progress,
adds Phase 8; updates total to 19 PRs
- PR breakdown: adds full Phase 8 spec with per-PR deliverables
- Marks PR 7.3 as blocked on Phase 8
docs/release/post_v1_roadmap.md
- Adds 4 [Phase-8 deferred] items to DGP-deepening:
- Difficulty axis as genuine AUC separation (not just prevalence)
- Account-level GroupKFold split as first-class task variant
- Missing B2B signals v2 feature set (7 prioritised signals)
- Hidden DAG as executable causal engine
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #81 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Integrates the findings from the 2026-05-25 three-model external review (Claude, ChatGPT, Gemini — standard + extended thinking each) of the v1 release preview site into the planning corpus.
Files changed
New
docs/external_review/summaries/v1_release_review_synthesis.md— full de-duplicated, cross-pollinated synthesis across all 6 review runs, covering §1 Codebase, §2 Dataset data, §3 Presentation, §4 Integration script (LeadForge-side issues confirmed after ShmuggingFace dev triage)Updated
.agent-plan.md— Phase 8 (4 PRs) inserted between PR 7.2.2 and PR 7.3; PR 7.3 marked as depending on Phase 8docs/release/v1_release_roadmap.md— phase summary table updated (phases 1-6 ✓, Phase 7 in-progress, Phase 8 added; total 15→19 PRs); full Phase 8 PR breakdown addeddocs/release/post_v1_roadmap.md— 4[Phase-8 deferred]DGP-deepening items added: difficulty axis as genuine AUC separation, account-level GroupKFold split, missing B2B signals (7 prioritised), hidden DAG as causal enginePhase 8 at a glance
has_open_opportunityleak, Gaussian clamp, dropfirst_touch_channel, renametouches_week_1, label window<=isPrivate: true, HF default tier →intro, calibration disclosure, acceptance-bands clarificationDeferred to post-v1
🤖 Generated with Claude Code