chore(release): add author attribution to README#94
Merged
Conversation
Add 'Created by Shay Palachy Affek' to the opening paragraph and a Credits section at the bottom of release/README.md (the source). release/huggingface/README.md is the packager-generated artifact. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #94 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
There was a problem hiding this comment.
Pull request overview
Adds author attribution for Shay Palachy Affek to the public release/README.md (opening paragraph + new Credits section at the bottom), and includes the corresponding regenerated Hugging Face dataset card artifact.
Changes:
- Opening paragraph now reads "Created by [Shay Palachy Affek] and generated by [leadforge]…" in both READMEs.
- New "## Credits" section appended with author link plus HuggingFace / Kaggle / GitHub profile links.
- Regenerated
release/huggingface/README.mdalso drops the non-standardauthors:YAML field from the dataset card frontmatter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| release/README.md | Adds attribution in intro paragraph and new Credits section. |
| release/huggingface/README.md | Regenerated packager artifact: mirrors attribution updates and drops manual authors: YAML key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shaypal5
added a commit
that referenced
this pull request
May 30, 2026
#98) Kaggle org `leadforge` does not exist; publish under the personal account `derelictpanda`. Regenerated dataset-metadata.json via package_kaggle_release.py, which also picks up the author-attribution changes from release/README.md (#94–#96). Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
shaypal5
added a commit
that referenced
this pull request
May 30, 2026
Four changes to satisfy Kaggle's "getting started" checklist:
1. **Cover image** – redesigned `generate_cover_image.py` to render a
funnel visualization (teal → amber → red sections, conversion %
labels, bokeh depth) alongside the title block and tier cards.
Regenerated `release/dataset-cover-image.png`.
2. **Resource names** – `Resource` dataclass was missing a `name` field,
so Kaggle had no slug for file-information display. Added `name: str = ""`
with path-based slug derivation in `_resource_to_dict`.
3. **Column descriptors** – task-split Parquet files (train/valid/test)
had field schemas without descriptions. Wired `feature_dict` through
as `snapshot_col_descs` so every ML column gets its description from
`feature_dictionary.csv`.
4. **Author attribution on HF cards** – `HuggingFaceCard` was missing an
`authors` field; added it (default `("shaypal5",)`), emitted between
`license` and `language` in YAML frontmatter. Regenerated public
README, instructor README (already matched), and preview HTMLs.
Also expanded Kaggle link allowlist in tests to cover attribution hrefs
added in #94–#96.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Shay Palachy Affek attribution in two places in release/README.md: (1) opening paragraph, (2) new Credits section at the bottom. release/huggingface/README.md is the regenerated packager artifact.
🤖 Generated with Claude Code