fix(tests): add author profile URLs to HF preview allowlist + regen sample#97
Merged
Conversation
…ample The attribution links added to release/README.md (shaypalachy.com, huggingface.co/shaypal5, kaggle.com/derelictpanda, github.com/shaypalachy) were not in _LINK_OK_PREFIXES, causing test_public_rendered_links_point_at_known_targets to fail. Also regenerate the committed preview sample to match the updated README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds new external author/profile URLs to the HuggingFace preview link allowlist and regenerates the committed preview HTML snapshot to match the updated release/README.md (which now includes author attribution and a Credits section).
Changes:
- Extends
_LINK_OK_PREFIXESintests/scripts/test_preview_hf_page.pywith author profile URLs (shaypalachy.com, huggingface.co/shaypal5, kaggle.com/derelictpanda, github.com/shaypalachy). - Regenerates
release/_preview_committed/huggingface_public.htmlto reflect new attribution text, an inlined macro framing, and a new Credits section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/scripts/test_preview_hf_page.py | Adds new author/profile URL prefixes to the allowlist so the link-target test passes. |
| release/_preview_committed/huggingface_public.html | Regenerated snapshot reflecting new author attribution, inlined macro footnote, and Credits section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
pr-agent-context report: No unresolved review comments, failing checks, or actionable patch coverage gaps were found on PR #97 in repository https://github.com/leadforge-dev/leadforge. Treat this PR as all clear unless new signals appear.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two CI failures introduced by the attribution links added to
release/README.md:test_public_rendered_links_point_at_known_targets— addsshaypalachy.com,huggingface.co/shaypal5,kaggle.com/derelictpanda,github.com/shaypalachyto_LINK_OK_PREFIXEStest_committed_public_sample_matches_fresh_regeneration— regeneratesrelease/_preview_committed/huggingface_public.htmlto match the updated README🤖 Generated with Claude Code