refactor: move attestation aggregation to natural homes#512
Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom Apr 6, 2026
Merged
Conversation
Move `State.aggregate()` and `State._select_proofs_greedily()` out of State, which only used `self.validators` as a lookup table. - `select_greedily` → `AggregatedSignatureProof.select_greedily()` completes the proof lifecycle (select, aggregate, verify) - Aggregation orchestration → `Store.aggregate()` which owns all three input pools (gossip sigs, new payloads, known payloads) - Proof compaction → inlined in `State.build_block()` where it is used No new files or types introduced. Tests updated to go through Store. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
State.aggregate()andState._select_proofs_greedily()out ofState, which only usedself.validatorsas a read-only lookup tableselect_greedily→AggregatedSignatureProof.select_greedily()— completes the proof lifecycle (select, aggregate, verify)Store.aggregate()which owns all three input pools (gossip sigs, new payloads, known payloads)State.build_block()where it's the sole callerTest plan
uv run pytest tests/lean_spec/subspecs/containers/test_state_aggregation.py— 9 passeduv run pytest tests/lean_spec/subspecs/forkchoice/test_store_attestations.py— 20 passeduv run pytest tests/lean_spec/subspecs/forkchoice/test_attestation_target.py— 17 passeduvx tox -e all-checks— all green (ruff, format, ty, codespell, mdformat)🤖 Generated with Claude Code