chore: modulize tests (N/N)#34466
Draft
Komyyy wants to merge 44 commits intoleanprover-community:masterfrom
Draft
chore: modulize tests (N/N)#34466Komyyy wants to merge 44 commits intoleanprover-community:masterfrom
Komyyy wants to merge 44 commits intoleanprover-community:masterfrom
Conversation
PR summary 92e168a21cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
3 tasks
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
Komyyy
added
blocked-by-core-release
Komyyy
added
CI
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
Komyyy
added
the
blocked-by-other-PR
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
Komyyy
added
blocked-by-core-release
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
Komyyy
added a commit
to Komyyy/mathlib4
that referenced
this pull request
Mar 22, 2026
--- Privately imports are intentional. I manually modulize each test so that the purpose of the tests is not lost by modulizing. This PR is extracted from draft PR leanprover-community#34466. These tests are for tactics, which can modulize by simply adding `module`.
mathlib-dependent-issues
bot
added
blocked-by-other-PR
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
Komyyy
added a commit
to Komyyy/mathlib4
that referenced
this pull request
Apr 5, 2026
--- --- Privately imports are intentional. I manually modulize each test so that the purpose of the tests is not lost by modulizing. This PR is extracted from draft PR leanprover-community#34466. * Adds `local`s for `notation`s * Drops `private`s except `private axiom test_sorry : ∀ {α}, α`s, to prevent abuse when `test_sorry` accidentially enters a public section * In `MathlibTest.Linarith.Basic`, `meta` for `testSorryTac` is unnecessary for building, but desirable for robustness.
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
3 tasks
Komyyy
added a commit
to Komyyy/mathlib4
that referenced
this pull request
Apr 9, 2026
Found while modulizing tests in leanprover-community#34466. This can be fixed straightforwardly by making internal lemmas public.
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
`norm_num` used to generate proof terms containing private lemmas, leading to errors in downstream modules. Fix this by making the lemmas public; they are still namespaced (so unlikely to lead to confusion elsewhere). Found while modulizing tests in #34466. Co-authored-by: Komyyy <pol_tta@outlook.jp>
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Apr 10, 2026
…rover-community#37820) `norm_num` used to generate proof terms containing private lemmas, leading to errors in downstream modules. Fix this by making the lemmas public; they are still namespaced (so unlikely to lead to confusion elsewhere). Found while modulizing tests in leanprover-community#34466. Co-authored-by: Komyyy <pol_tta@outlook.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Privately imports are intentional.
I manually modulize each test so that the purpose of the tests is not lost by modulizing.
attribute [local simp]for a privately imported theorem throws error leanprover/lean4#12198local elabcannot use privately imported meta defs leanprover/lean4#13329