Skip to content

chore: Rename Xor' to Xor#37628

Open
JadAbouHawili wants to merge 14 commits intoleanprover-community:masterfrom
JadAbouHawili:master
Open

chore: Rename Xor' to Xor#37628
JadAbouHawili wants to merge 14 commits intoleanprover-community:masterfrom
JadAbouHawili:master

Conversation

@JadAbouHawili
Copy link
Copy Markdown
Contributor

@JadAbouHawili JadAbouHawili commented Apr 4, 2026

Rename Xor' to Xor per the comment which recommended doing so after v4.25.0-rc1

Moves:

  • Xor' --> Xor

#new members > Why Xor' and not Xor? Why `Or` and not `OrOp` for `Prop`? @ 💬


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@JadAbouHawili
Copy link
Copy Markdown
Contributor Author

relevant zulip thread: here

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 2e1ad590c1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Xor
+ Xor.or
+ dense_xor_cyclic
+ exists_isOpen_xor_mem
+ instance : Std.Commutative Xor := ⟨xor_comm⟩
+ instance [Decidable a] [Decidable b] : Decidable (Xor a b) := inferInstanceAs (Decidable (Or ..))
+ symmDiff_eq_Xor
+ symmDiff_eq_xor
+ t0Space_iff_exists_isOpen_xor_mem
+-+ even_xor_odd
+-+ even_xor_odd'
- Xor'.or
- instance : Std.Commutative Xor' := ⟨xor_comm⟩
- instance [Decidable a] [Decidable b] : Decidable (Xor' a b) := inferInstanceAs (Decidable (Or ..))
- symmDiff_eq_Xor'

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.01)
Current number Change Type
167 -1 adaptation notes

Current commit a05ee23873
Reference commit 2e1ad590c1

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Algebra/Ring/Int/Parity.lean Outdated
Comment thread Mathlib/Logic/Basic.lean
Comment thread Mathlib/Order/SymmDiff.lean Outdated
Comment thread Mathlib/Topology/Algebra/Order/Archimedean.lean Outdated
Comment thread Mathlib/Topology/Separation/Basic.lean Outdated
Comment thread Mathlib/Topology/Separation/Basic.lean Outdated
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 4, 2026
@JadAbouHawili
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 4, 2026
@JadAbouHawili JadAbouHawili changed the title doc: Rename Xor' to Xor chore: Rename Xor' to Xor Apr 4, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants