feat: add Function.prod and Function.diag#37631
feat: add Function.prod and Function.diag#37631linesthatinterlace wants to merge 12 commits intoleanprover-community:masterfrom
Function.prod and Function.diag#37631Conversation
PR summary f51efbe0b8Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Function.prod and Function.diagFunction.prod and Function.diag
SnirBroshi
left a comment
There was a problem hiding this comment.
This looks very cool!
| variable {α β γ δ : Type*} {ι : Sort*} | ||
|
|
||
| /-- The map into a product type built from maps into each component. -/ | ||
| protected def prod : (ι → α) → (ι → β) → ι → α × β := (· ▽' ·) |
There was a problem hiding this comment.
Question:
I don't understand why we need both Pi.prod and Function.prod. Can't we have just the general version (Pi.prod)? (Related: #36902)
If the issue is dot notation, then it's worth mentioning that leanprover/lean4#1629 had some progress recently.
| / ▽ | ||
| c - - - ▷ a | ||
| / ▼ | ||
| c - - - ▶ a |
There was a problem hiding this comment.
This change is surely out of scope
This PR adds
Function.prodandFunction.diagand develops API for them andPi.prod.