chore(Combinatorics/SimpleGraph): tidy various files#37642
Open
SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
Open
chore(Combinatorics/SimpleGraph): tidy various files#37642SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 290b6cf8beImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
SnirBroshi
commented
Apr 4, 2026
| def overFin (hc : Fintype.card V = n) : SimpleGraph (Fin n) where | ||
| Adj x y := G.Adj ((Fintype.equivFinOfCardEq hc).symm x) ((Fintype.equivFinOfCardEq hc).symm y) | ||
| symm x y := by simp_rw [adj_comm, imp_self] | ||
| noncomputable def overFin (hc : Fintype.card V = n) : SimpleGraph (Fin n) := |
Collaborator
Author
There was a problem hiding this comment.
btw I have no idea why this became noncomputable, this is defeq to the previous definition, but now it complains about the usage of Fintype.equivFinOfCardEq which was already there before.
Perhaps putting it inside Adj which is a Prop makes Lean realize this will be deleted at runtime, but not when it's a parameter to comap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concept inspired by @Ruben-VandeVelde :)