Skip to content

chore(Combinatorics/SimpleGraph): tidy various files#37642

Open
SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
SnirBroshi:chore/simple-graph/tidy-1
Open

chore(Combinatorics/SimpleGraph): tidy various files#37642
SnirBroshi wants to merge 3 commits intoleanprover-community:masterfrom
SnirBroshi:chore/simple-graph/tidy-1

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

@SnirBroshi SnirBroshi commented Apr 4, 2026


Concept inspired by @Ruben-VandeVelde :)

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 290b6cf8be

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Colorable.chromaticNumber_pos
+ Copy.maxDegree_le
+ IsContained.maxDegree_le
+ IsSubwalk.darts_infix
+ IsSubwalk.edges_infix
+ isSubwalk_iff_darts_infix
+ isSubwalk_iff_support_infix
+ support_take

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-combinatorics Combinatorics label Apr 4, 2026
def overFin (hc : Fintype.card V = n) : SimpleGraph (Fin n) where
Adj x y := G.Adj ((Fintype.equivFinOfCardEq hc).symm x) ((Fintype.equivFinOfCardEq hc).symm y)
symm x y := by simp_rw [adj_comm, imp_self]
noncomputable def overFin (hc : Fintype.card V = n) : SimpleGraph (Fin n) :=
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I have no idea why this became noncomputable, this is defeq to the previous definition, but now it complains about the usage of Fintype.equivFinOfCardEq which was already there before.
Perhaps putting it inside Adj which is a Prop makes Lean realize this will be deleted at runtime, but not when it's a parameter to comap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant