Skip to content

[Merged by Bors] - feat(CategoryTheory/Limits): sigmaConst preserves colimits#37645

Closed
joelriou wants to merge 15 commits intoleanprover-community:masterfrom
joelriou:sigma-const-preserves-colimits
Closed

[Merged by Bors] - feat(CategoryTheory/Limits): sigmaConst preserves colimits#37645
joelriou wants to merge 15 commits intoleanprover-community:masterfrom
joelriou:sigma-const-preserves-colimits

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Apr 4, 2026

More precisely sigmaConst.obj R commutes with colimits. We also compute the cokernel of (sigmaConst.obj R).map f when f is a map in Type*.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Apr 4, 2026
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 0286ecda71

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
5 files Mathlib.Algebra.Category.ModuleCat.Sheaf.Free Mathlib.Algebra.Category.ModuleCat.Sheaf.Generators Mathlib.Algebra.Category.ModuleCat.Sheaf.PullbackFree Mathlib.Algebra.Category.ModuleCat.Sheaf.Quasicoherent Mathlib.AlgebraicGeometry.Modules.Tilde
1
Mathlib.CategoryTheory.Limits.Preserves.SigmaConst (new file) 466

Declarations diff

+ freeFunctor_map
+ freeFunctor_obj
+ instance :
+ instance [HasCoproducts.{w} C] (R : C) :
+ instance [HasCoproducts.{w} C] {α β : Type w} (f : α ⟶ β) :
+ isColimitSigmaConstCokernelCofork
+ sigmaConstCokernelCofork
+ ι_sigmaConstCokernelCofork_π
+ ι_sigmaConstCokernelCofork_π_eq_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6503 1 backward.isDefEq.respectTransparency

Current commit 97d53cdbeb
Reference commit 0286ecda71

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 4, 2026
@joelriou joelriou added the WIP Work in progress label Apr 7, 2026
Comment thread Mathlib/CategoryTheory/Limits/Preserves/SigmaConst.lean Outdated
Comment thread Mathlib/CategoryTheory/Limits/Preserves/SigmaConst.lean
Comment thread Mathlib/Algebra/Category/ModuleCat/Sheaf/Free.lean Outdated
@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 9, 2026
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 10, 2026
Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of definition for freeFunctor is a definitive win here.
The remaining backward.isDefEq.respectTransparency seems a bit annoying to remove here...
Thanks!

maintainer delegate

Comment thread Mathlib/CategoryTheory/Limits/Preserves/SigmaConst.lean Outdated
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 13, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 15, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 16, 2026
More precisely `sigmaConst.obj R` commutes with colimits. We also compute the cokernel of `(sigmaConst.obj R).map f` when `f` is a map in `Type*`.
@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 16, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Limits): sigmaConst preserves colimits [Merged by Bors] - feat(CategoryTheory/Limits): sigmaConst preserves colimits Apr 16, 2026
@mathlib-bors mathlib-bors bot closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants