Skip to content

chore: make argument in bddAbove_of_small implicit#37648

Open
vihdzp wants to merge 9 commits intoleanprover-community:masterfrom
vihdzp:bddAbove
Open

chore: make argument in bddAbove_of_small implicit#37648
vihdzp wants to merge 9 commits intoleanprover-community:masterfrom
vihdzp:bddAbove

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 4, 2026

We use the theorem with an implicit argument much more (~40 times) than we use it with an explicit one (twice).

We also deprecate the redundant bddAbove_range lemmas.


Open in Gitpod

@vihdzp vihdzp added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-set-theory Set theory labels Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary 53f40a86f2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

--++ bddAbove_of_small

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant