[Merged by Bors] - ci: skip cache warmup if the "previous" commit uses a different toolchain#37653
Closed
bryangingechen wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 2050ca5474Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
CI
YaelDillies
approved these changes
Apr 5, 2026
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
mathlib-triage
bot
added
the
maintainer-merge
adomani
reviewed
Apr 5, 2026
Contributor
adomani
left a comment
adomani
left a comment
There was a problem hiding this comment.
Thanks!
I'm happy to try this quickly, I'm simply not sure about trailing line break being handled correctly.
Feel free to merge once you are available to fix potential issues!
bors d+
Contributor
|
✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
bot
added
delegated
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
…hain (#37653) #37564 changed `cache` so that it looks for a bundled `leantar` rather than downloading a copy. This caused the "warmup cache" step introduced in #36623 to break since the "previous" commit being fetched could be using an older toolchain. We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways. Prepared with claude code.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
to riccardobrasca/mathlib4
that referenced
this pull request
Apr 6, 2026
…hain (leanprover-community#37653) leanprover-community#37564 changed `cache` so that it looks for a bundled `leantar` rather than downloading a copy. This caused the "warmup cache" step introduced in leanprover-community#36623 to break since the "previous" commit being fetched could be using an older toolchain. We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways. Prepared with claude code.
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Apr 6, 2026
…hain (leanprover-community#37653) leanprover-community#37564 changed `cache` so that it looks for a bundled `leantar` rather than downloading a copy. This caused the "warmup cache" step introduced in leanprover-community#36623 to break since the "previous" commit being fetched could be using an older toolchain. We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways. Prepared with claude code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37564 changed
cacheso that it looks for a bundledleantarrather than downloading a copy. This caused the "warmup cache" step introduced in #36623 to break since the "previous" commit being fetched could be using an older toolchain.We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways.
Prepared with claude code.