fix: pass Lake module setup to highlighted extractor#222
Open
ejgallego wants to merge 4 commits into
Open
Conversation
ejgallego
force-pushed
the
codex/highlighted-lake-setup
branch
from
July 3, 2026 17:38
3e0dad3 to
a1eb3e3
Compare
ejgallego
changed the title
ejgallego
force-pushed
the
codex/highlighted-lake-setup
branch
2 times, most recently
from
July 3, 2026 18:44
c809243 to
feb86d0
Compare
ejgallego
changed the title
ejgallego
marked this pull request as ready for review
July 6, 2026 11:44
Contributor
Author
|
CI problems seem to be also present upstream, investigating. Otherwise this PR is ready for review. |
ejgallego
force-pushed
the
codex/highlighted-lake-setup
branch
from
July 7, 2026 14:28
db5981c to
af2adcc
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix highlighted source extraction for modules whose Lake build context includes setup data, such as dynamic libraries.
The highlighted module facet now passes Lake's module setup file to
subverso-extract-modwhen Lake exposes one. The extractor loads that setup before elaboration, so extraction sees the same imports, options, plugins, import artifacts, dynamic libraries, and package metadata as the module build. Older Lake versions continue using the existing extractor arguments.This adds an FFI regression fixture that builds a dynamic library and checks
Ffi:highlighted. The fixture runs on Lean 4.27 and newer; setup files exist in some earlier module-system releases, but this fixture's extern#evalfails during the module build before SubVerso extraction runs there.Related: #221 , thanks to @kim-em for submitting the report and a preliminary fix.