Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces infoview re-renders (1.) and simplifies the build setup (2.) Fixes leanprover-community/ProofWidgets4#176.
InfoAuxfetches goals and widgets whenever theObject.is-identity oflspDiagsHerechanges. The React effect that setslspDiagsHeretries to maintain its identity, but it used to do so by comparingLeanDiagnostics for===-identity. We now usereact-fast-compare-identity. We do not try to memoize earlier in the data flow (e.g. when settingLspDiagnosticsContext) in any principled way.The
===-comparison was never correct - fresh diagnostic objects are created on everypublishDiagnostics- but the issue was primarily exposed by feat: 'unsolved goals' & 'goals accomplished' diagnostics lean4#7366 which produces a hidden diagnostic on every declaration, so thatlspDiagsHereis recomputed at most positions.We remove Lerna, leaving only Nx (which Lerna uses under the hood). This unbreaks building in a worktree folder nested within the main repo folder (
vscode-lean4/worktree-my-branch/). This also drops ~400 transitive dependencies and should otherwise be functionally equivalent.