Conversation
leissa
commented
May 8, 2026
leissa
commented
Owner
- updated badges
- enhanced fe/format.h
* updated badges * enhanced fe/format.h
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the fe header-only library baseline to C++23 and expands include/fe/format.h with additional formatting helpers intended to improve ergonomics when using std::format and streaming.
Changes:
- Bump the library’s CMake compile features from C++20 to C++23.
- Update documentation badges/text to reflect the C++23 baseline.
- Enhance
fe/format.hwith new formatted-output helpers (Tab::print*), anfe::StreamFnwrapper, and anfe::joinrange adapter withstd::formattersupport.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| include/fe/format.h | Adds new formatting utilities (StreamFn, Join/join, Tab::print*), and updates ostream formatter implementation. |
| docs/README.md | Updates badges and README wording to C++23. |
| CMakeLists.txt | Switches the fe interface target to require cxx_std_23. |
We have deduction guides for fe::Join
Comment on lines
+167
to
+168
| out = std::ranges::copy(sep, out).out; | ||
| out = elem_fmt.format(elem, ctx); |
| }; | ||
|
|
||
| /// Join elements of @p range with @p sep. | ||
| /// Use as a `std::format` or `operator<<` argument: `std::format("{}", fe::join(v, ", "))`. |
Comment on lines
+190
to
+195
| # define assertf(condition, ...) \ | ||
| do { \ | ||
| if (!(condition)) { \ | ||
| std::println(std::cerr, "{}:{}: assertion: ", __FILE__, __LINE__); \ | ||
| std::println(std::cerr, __VA_ARGS__); \ | ||
| fe::breakpoint(); \ |
Owner
Author
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/leissa/fe/sessions/e4abd5b4-0cc5-4f01-8ef0-4b1a7f979156 Co-authored-by: leissa <8067180+leissa@users.noreply.github.com>
Agent-Logs-Url: https://github.com/leissa/fe/sessions/e4abd5b4-0cc5-4f01-8ef0-4b1a7f979156 Co-authored-by: leissa <8067180+leissa@users.noreply.github.com>
Contributor
Done in 96d0cd6 (plus e29ba0d): I applied the requested thread fixes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.