SODA: indexing + data guide (#203)#210
Merged
Merged
Conversation
Final step of the #163 SODA umbrella: - SodaCollection.createIndex(spec) — create an index from a dict / JSON spec (functional, search/data-guide, etc.). - SodaCollection.dropIndex(name) -> bool (True if one was dropped). - SodaCollection.getDataGuide() -> a SodaDocument with the collection's data-guide JSON, or None when there is no data-guide-enabled search index. RE notes: create_index / drop_index are functions (1 = created / dropped), get_data_guide returns a CLOB. With no data-guide index get_data_guide raises ORA-40582 — mapped to None to match oracledb. The JSON search index needs Oracle Text, which 21c XE lacks (ORA-29833), so that part of the test skips there; functional indexing works on 18c+. Sync + async; 23ai full, 21c functional index (data guide skipped), 11g/9i gated. Data-guide read keeps the 32767-byte inline limit. Closes #203 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final step of the #163 SODA umbrella.
API (sync + async)
collection.createIndex(spec)— create an index from a dict / JSON spec (functional, search/data-guide, …)collection.dropIndex(name)→ bool (True if one was dropped)collection.getDataGuide()→ aSodaDocumentwith the collection's data-guide JSON, orNonewhen there's no data-guide-enabled search indexRE notes
create_index/drop_indexare functions (1 = created/dropped);get_data_guidereturns a CLOB.get_data_guideraises ORA-40582 — mapped toNoneto match oracledb.Tests: live createIndex/dropIndex (present/absent), getDataGuide (none → None, and the parsed structure where Text is available) — sync + async, 23ai full, 21c functional, 11g/9i gated. Offline suite green. Data-guide read keeps the 32767-byte inline limit.
Closes #203
🤖 Generated with Claude Code