Skip to content

feat: add debug config in lenra.yml - #203

Merged
taorepoara merged 11 commits into
betafrom
shiipou/issue202
Apr 7, 2023
Merged

feat: add debug config in lenra.yml #203
taorepoara merged 11 commits into
betafrom
shiipou/issue202

Conversation

@shiipou

@shiipou shiipou commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

This allow to debug code in each lenra template app.
Example : lenra-io/template-javascript#12

Comment thread src/docker_compose.rs
Co-authored-by: Thomas DA ROCHA <8969556+taorepoara@users.noreply.github.com>
@taorepoara

Copy link
Copy Markdown
Member

To fix the timeout problem in debug mod, we should add the next env vars to the app container:

      exec_timeout: "3600"
      read_timeout: "3600"
      write_timeout: "3600"

Should be added by the dofigen_of_overlay method and not only in debug mode, but always.

@taorepoara

Copy link
Copy Markdown
Member

You have to update the CLI documentation files.

@shiipou shiipou linked an issue Mar 14, 2023 that may be closed by this pull request
Comment thread src/config.rs Outdated
Comment thread src/docker_compose.rs Outdated
because we can't use `?` on `Option`,
it'll work with `Result` or any struct taht implement `try` trait.
@Nesqwik
Nesqwik removed their request for review April 6, 2023 12:05
taorepoara
taorepoara previously approved these changes Apr 7, 2023

@taorepoara taorepoara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@taorepoara
taorepoara merged commit 7ca42a3 into beta Apr 7, 2023
@taorepoara
taorepoara deleted the shiipou/issue202 branch April 7, 2023 13:27
@github-actions

github-actions Bot commented Apr 7, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-beta.26 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Apr 7, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-beta.26 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

taorepoara added a commit that referenced this pull request Sep 29, 2023
Co-authored-by: Thomas DA ROCHA <8969556+taorepoara@users.noreply.github.com>
Co-authored-by: Thomas DA ROCHA <thomas.darocha@lenra.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add debug config in lenra.yml

2 participants