Skip to content

cert-checker: Allow scraping pprof data #8833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beautifulentropy wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −6
Open

cert-checker: Allow scraping pprof data #8833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43c7a0
cert-checker: Allow scraping pprof data
beautifulentropy Jul 1, 2026
339acc9
Add debugAddr to config-next
beautifulentropy Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cmd/cert-checker/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,8 @@ type Config struct {
DB cmd.DBConfig
cmd.HostnamePolicyConfig

DebugAddr string `validate:"omitempty,hostname_port"`

Workers int `validate:"required,min=1"`
// LookupDNSAuthority can only be specified with PushgatewayService. It's a single
// <hostname|IPv4|[IPv6]>:<port> of the DNS server to be used for resolution
Expand Down Expand Up @@ -634,6 +636,7 @@ func getPushgatewayURL(ctx context.Context, dnsAuthority string, svc cmd.Service
}

func main() {
debugAddr := flag.String("debug-addr", "", "Debug server address override")
configFile := flag.String("config", "", "File path to the configuration file for this service")
flag.Parse()
if *configFile == "" {
Expand All @@ -645,13 +648,17 @@ func main() {
err := cmd.ReadConfigFile(*configFile, &config)
cmd.FailOnError(err, "Reading JSON config file into config structure")

if *debugAddr != "" {
config.CertChecker.DebugAddr = *debugAddr
}

features.Set(config.CertChecker.Features)

logger := cmd.NewLogger(config.Syslog)
stats, logger, oTelShutdown := cmd.StatsAndLogging(config.Syslog, cmd.OpenTelemetryConfig{}, config.CertChecker.DebugAddr)
defer oTelShutdown(context.Background())
cmd.LogStartup(logger)

reg := prometheus.NewRegistry()
metrics := newCertCheckerMetrics(reg)
metrics := newCertCheckerMetrics(stats)

acceptableValidityDurations := make(map[time.Duration]bool)
if len(config.CertChecker.AcceptableValidityDurations) > 0 {
Expand Down Expand Up @@ -746,7 +753,7 @@ func main() {
if err != nil {
logger.Error(ctx, "failed to get pushgateway URL", err)
} else {
err = cmd.PushMetrics("cert-checker", pushgatewayURL, reg, logger)
err = cmd.PushMetrics("cert-checker", pushgatewayURL, stats, logger)
if err != nil {
logger.Error(ctx, "failed to push metrics to pushgateway", err, slog.String("url", pushgatewayURL))
} else {
Expand Down
4 changes: 2 additions & 2 deletions cmd/shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ var backupLogger singletonLogger
// is called, because gRPC's SetLogger doesn't use any locking.
//
// This function does not return an error, and will panic on problems.
func StatsAndLogging(logConf blog.Config, otConf OpenTelemetryConfig, addr string) (prometheus.Registerer, blog.Logger, func(context.Context)) {
func StatsAndLogging(logConf blog.Config, otConf OpenTelemetryConfig, addr string) (*prometheus.Registry, blog.Logger, func(context.Context)) {
logger := NewLogger(logConf)

shutdown := NewOpenTelemetry(otConf, logger)
Expand Down Expand Up @@ -265,7 +265,7 @@ func newVersionCollector() prometheus.Collector {
)
}

func newStatsRegistry(addr string, logger blog.Logger) prometheus.Registerer {
func newStatsRegistry(addr string, logger blog.Logger) *prometheus.Registry {
registry := prometheus.NewRegistry()

if addr == "" {
Expand Down
1 change: 1 addition & 0 deletions test/config-next/cert-checker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"certChecker": {
"debugAddr": ":8007",
"db": {
"dbConnectFile": "test/secrets/cert_checker_dburl",
"maxOpenConns": 10
Expand Down