Apply LimitedReader structs to all io.ReadAll calls.#8834
Open
ezekiel wants to merge 4 commits into
Open
Conversation
aarongable
reviewed
Jul 1, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
High-level comments:
- Let's not bother in all the test files (definitely foo_test.go, and maybe test/blah at your discretion)
- Let's crank down the limit for most of these (100MB is too many)
- Let's crank up the limit specifically for anything reading CRLs, since those could exceed 100MB in a mass revocation event
- Maybe a
core.ReadAtMost(reader, limit)helper with accompanyingcore.DefaultMaxReadconst? Also up to you.
Reduce to still very generous ~300K normal reader size. Increase to ~1G CRL reader size.
Member
Author
|
This reduced set of changes gets us good coverage for production code that we can deploy with lower impact risks. And we still have the option to put up a second iteration with a core helper. |
aarongable
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8823