observer: Fix possible panic in TLSProbe check#8836
Open
beautifulentropy wants to merge 1 commit into
Open
Conversation
ezekiel
approved these changes
Jul 1, 2026
aarongable
reviewed
Jul 2, 2026
Comment on lines
212
to
+213
| root := peers[len(peers)-1].Issuer | ||
| err = p.checkRoot(root.Organization[0], root.CommonName) | ||
| err = p.checkRoot(root) |
Contributor
There was a problem hiding this comment.
The root variable is only used in one place now; inline it into p.checkRoot(peers[len(peers)-1].Issuer).
| if (p.rootCN == "" && p.rootOrg == "") || (rootOrg == p.rootOrg && rootCN == p.rootCN) { | ||
| func (p TLSProbe) checkRoot(root pkix.Name) error { | ||
| var rootOrg string | ||
| if len(root.Organization) > 0 { |
Contributor
There was a problem hiding this comment.
I'd say if len(root.Organization) != 1 { return errors.New("...") }, and then proceed with root.Organization[0] after that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8822