Skip to content

Disable PR workflow for JP branches #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rucoder wants to merge 1 commit into
base: eve-kernel-amd64-v6.12.49-generic
Choose a base branch
from
+2 −0
Draft

Disable PR workflow for JP branches #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on: # yamllint disable-line rule:truthy
branches:
- "gha-test-rebase"
- "eve-kernel-*"
Copy link
Copy Markdown
Collaborator

@rene rene Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rucoder , what about if we just set here eve-kernel-amd64-* instead of eve-kernel-* ?

- "!eve-kernel-arm64-v5.15.136-nvidia-jp6"
- "!eve-kernel-arm64-v5.10.192-nvidia-jp5"
Comment on lines +8 to +9
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negation pattern syntax used here will not work as intended in GitHub Actions. When using branches filter in pull_request_target, you cannot use negation patterns (with ! prefix) to exclude specific branches from a wildcard pattern.

The correct approach is to use branches-ignore alongside branches, or to specify explicit branch patterns. Consider one of these alternatives:

  1. Use a combination of branches and branches-ignore (note they cannot be used together, so you'd need to rethink the filter strategy)
  2. List all desired branches explicitly without wildcards
  3. Use an if condition in the job level to check and skip the JP branches

For example, you could add a condition at the job level:

jobs:
  build:
    if: |
      !startsWith(github.event.pull_request.base.ref, 'eve-kernel-arm64-v5.15.136-nvidia-jp6') &&
      !startsWith(github.event.pull_request.base.ref, 'eve-kernel-arm64-v5.10.192-nvidia-jp5')

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

@rucoder rucoder Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene oh, GHA are SO limited... I have no good words...

paths-ignore:
- ".github/**"

Expand Down