gh-workflows: make cache hits optional in eve build jobs#5734
Closed
europaul wants to merge 3 commits intolf-edge:masterfrom
Closed
gh-workflows: make cache hits optional in eve build jobs#5734europaul wants to merge 3 commits intolf-edge:masterfrom
europaul wants to merge 3 commits intolf-edge:masterfrom
Conversation
eriknordmark
approved these changes
Apr 8, 2026
Contributor
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
We seem to be getting
Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: linuxkit-amd64-bfa34420ddb162ede9036e29fa8f6b360d47fdb1-generic-k
for many (but not all) of the PRs.
I don't know whether this will help or whether it will make the builds exceed the total time allowed on the runner.
But if we think it can help we can give it a try.
europaul
force-pushed
the
gh-workflows/optional-cache-for-eve-build
branch
from
6749c1d to
3968b50
Compare
Contributor
Author
|
GitHub Actions cache entries expire too quickly, so between the packages job and the eve job they are often already gone. This causes the eve job to fail on cache miss rather than just rebuilding. Make the cache restore steps non-fatal by removing fail-on-cache-miss and gating the docker-load steps on actual cache hits. Change the eve build step to run 'make pkgs eve' instead of just 'make eve' so that if the cache was not restored, packages are simply rebuilt. Add qemu setup to the eve job for riscv64, since it cross-builds on amd64 runners and needs qemu if packages must be rebuilt from scratch. Applied to both build.yml (PR builds) and buildondemand.yml (on-demand builds). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paul Gaiduk <paulg@zededa.com>
The paths-ignore filter excluded all of .github/**, which meant changes to the build workflow itself would not trigger a PR build. Add a negation pattern to re-include build.yml so the workflow can validate its own changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
force-pushed
the
gh-workflows/optional-cache-for-eve-build
branch
2 times, most recently
from
fbcb710 to
14aad05
Compare
Remove dead 'ensure zstd for cache' step in build.yml that referenced nonexistent matrix.os with stale runner names. Add .github/actionlint.yaml to whitelist custom self-hosted runner labels (zededa-ubuntu-2204, zededa-ubuntu-2204-arm64, jumbo). Pass pull_request.head.ref through an environment variable instead of using it directly in an inline script to prevent potential script injection from malicious branch names. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
force-pushed
the
gh-workflows/optional-cache-for-eve-build
branch
from
14aad05 to
220e039
Compare
rene
reviewed
Apr 9, 2026
| inputs: | ||
| command: | ||
| required: true | ||
| type: string |
Contributor
Author
There was a problem hiding this comment.
we hit this error from actionlint
e:.github/workflows/buildondemand.yml:71:15: could not parse action metadata in "/github/workspace/.github/actions/run-make": line 6: unexpected key "type" for definition of input "clean" [action]
I think those fields have been removed a long time ago - my local linter was always showing error. But since we have actionlint now in CI - it's an actual CI error to have them
rene
reviewed
Apr 9, 2026
| run: | # Runners must provide default credentials | ||
| docker login | ||
|
|
||
| - name: ensure packages for cross-arch build |
Contributor
There was a problem hiding this comment.
Why is this getting included again? We don't need it anymore since our runners are already prepared for binary emulation....
4 tasks
Contributor
Author
|
This PR is gonna be superseded by #5782 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub Actions cache entries expire too quickly, so between the packages job
and the eve job they are often already gone. This causes the eve job to fail
on cache miss rather than just rebuilding.
Make the cache restore steps non-fatal by removing
fail-on-cache-missandgating the docker-load steps on actual cache hits. Change the eve build step
to run
make pkgs eveinstead of justmake eveso that if the cache wasnot restored, packages are simply rebuilt.
Applied to both
build.yml(PR builds) andbuildondemand.yml(on-demandbuilds).
publish.ymlis not affected since it pushes packages to Docker Huband the eve job pulls from the registry.
How to test and validate this PR
warm (packages job finishes quickly and cache is still valid) and when the
cache has expired (eve job rebuilds packages via
make pkgs eve).workflow_dispatch) and verify the samebehavior for arm64/riscv64 matrix entries.
Changelog notes
No user-facing changes.
PR Backports
Checklist
check them.
🤖 Generated with Claude Code