Unify partition layout: 2GB (EFI) + 4GB (rootfs)#5735
Unify partition layout: 2GB (EFI) + 4GB (rootfs)#5735eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
183a8df to
5e73a72
Compare
|
@rene wy we need 2GB for EFI? even windows uses ~300Mb for dual boot |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5735 +/- ##
===========================================
+ Coverage 19.52% 29.87% +10.34%
===========================================
Files 19 18 -1
Lines 3021 2417 -604
===========================================
+ Hits 590 722 +132
+ Misses 2310 1549 -761
- Partials 121 146 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@rucoder , for now the only reason is solely to keep compatibility with eve-k, so both have the same size. There was a discussion in the past about change the boot mechanism to be more compatible with standard schemes, where kernel + initrd stays in the EFI partition and also put more dtbs and other firmware files required for Raspberry Pi and other arm64 devices. Open room for EVE 2.0 (if needed) was also considered. Is 2GB exaggerated? I think so, but TBH I wasn't involved in all these discussions and I don't recall all the details, I believe there were more plans to justify this size. I don't mind to reduce the EFI size, but at the same time, I don't see issues to just follow what is in eve-k and keep a very big room for feature changes that won't hit us with space issues again. So my final vote is just to keep it as it is (2GB).... |
5e73a72 to
c4b0827
Compare
c4b0827 to
66dc588
Compare
|
Updates in this PR:
|
66dc588 to
d5a4d19
Compare
eriknordmark
left a comment
There was a problem hiding this comment.
Run tests.
But does this imply that a test which does
make installer-raw run-installer-raw run-target
will use up lots more disk space compared to prior to the change?
Will this impact Eden runs?
|
Looks like all of the Eden steps fail. I didn't inspect why. |
|
Eden must be updated. Default EVE image size is 8GB: https://github.com/lf-edge/eve/actions/runs/24349483474/job/71230058791#step:4:565 I will open a PR on Eden.... |
In order to keep backward compatibility, the partition layout of non eve-k variants has been kept the same since version 10.2.0, where EFI and rootfs partitions (IMGA/IMGB) are partitioned as the following: * EFI - 36MB * IMGA - 512MB * IMGB - 512MB Commit 5db29bd fixed partition layout for eve-k as the following: * EFI - 2GB * IMGA - 4GB * IMGB - 4GB This new layout allows not only the growing of rootfs but also the growing of EFI space for new features, if required. This commit unifies partition layout across all EVE variants, so all images should have the same scheme: EFI (2GB), IMGA/IMGB (4GB). The 300MB limitation is not changed, so generic rootfs images can still be upgraded from the remote controller. However, for NVIDIA variants the maximum size is set to 4GB. This is a requirement for the Jetpack 7.1, which has exceeded the current size limit. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
d5a4d19 to
cad2729
Compare
|
FWIW 4/4 Eden smoke test failures in the known FAIL: TestHWInventory |
Description
In order to keep backward compatibility, the partition layout of non eve-k variants has been kept the same since version 10.2.0, where EFI and rootfs partitions (IMGA/IMGB) are partitioned as the following:
Commit 5db29bd fixed partition layout for eve-k as the following:
This new layout allows not only the growing of rootfs but also the growing of EFI space for new features, if required.
This commit unifies partition layout across all EVE variants, so all images should have the same scheme: EFI (2GB), IMGA/IMGB (4GB).
The 300MB limitation is not changed, so generic rootfs images can still be upgraded from the remote controller. However, for NVIDIA variants the maximum size is set to 4GB. This is a requirement for the Jetpack 7.1, which has exceeded the current size limit.
How to test and validate this PR
Run
lsblkand verify the size of the partitions match:Changelog notes
Unify partition layout to a consistent 2GB (EFI) + 4GB (rootfs) scheme across all EVE variants, including eve-k and eve-kvm, eliminating per-variant differences. This applies to freshly installed devices - no impact on already deployed devices.
PR Backports
This is a "new feature", so no backports.
Checklist
check them.