Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5740 +/- ##
===========================================
+ Coverage 19.52% 29.87% +10.34%
===========================================
Files 19 18 -1
Lines 3021 2417 -604
===========================================
+ Hits 590 722 +132
+ Misses 2310 1549 -761
- Partials 121 146 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
By bumping eve-libs Signed-off-by: eriknordmark <erik@zededa.com>
To try to make the incompatibility go away Signed-off-by: eriknordmark <erik@zededa.com>
Redirect to v28.5.1+incompatible Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: eriknordmark <erik@zededa.com>
eriknordmark
force-pushed
the
persistent
branch
from
3ec0d81 to
161b525
Compare
rene
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update eve-libs to latest to update the indirect use of go-jose to v4.1.4
This uses a redirect to avoid incompatibilities for the docker package. @shjala can we trigger a CVE scan so we can check that the redirect/version pin does not result in matching other CVEs?
The reachability analysis of the CVE is:
No non-vendor Go file in pkg/pillar imports go-jose at all. The library is
pulled in only as a transitive dependency via github.com/spiffe/go-spiffe/v2.
The spiffe bundle code uses go-jose only for JWK/JWS handling (JWT bundle
parsing), not JWE decryption with key-wrapping algorithms. ParseEncrypted,
ParseEncryptedJSON, ParseEncryptedCompact, and cipher.KeyUnwrap are never
invoked from EVE's application code.
For that reason there is no need to backport this. Just fixing master to keep things neat.
How to test and validate this PR
No special test instructions.
Changelog notes
Avoid any indirect use of v4.1.3 of github.com/go-jose/go-jose/v4 to avoid any possible issues related to CVE-2026-34986
PR Backports
Here is the list of current LTS branches (it should be always up to date):
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.
Please, check the boxes above after submitting the PR in interactive mode.