refactor: rename dbtSemantic identifiers to erdStudio with compat shims#49
Merged
Merged
Conversation
The extension kept its original dbtSemantic.* identifier scheme and a
"dbt" command palette category from before the ERD Studio rename, which
surfaced confusingly in the UI (palette showed "dbt: Create Domain",
settings grouped under the old prefix).
Rename commands, views, viewType, context keys, colors, and settings to
erdStudio.* ("erd-studio" container id, "ERD Studio" palette category).
Pre-rename users keep working via two shims: legacy dbtSemantic.*
command IDs stay registered in code as palette-hidden delegates (old
keybindings keep firing), and settings resolve through a helper that
prefers explicit erdStudio.* values then falls back to explicit
dbtSemantic.* values, with the old keys contributed as deprecated.
One-time cosmetic resets for existing users: activity bar position,
tree collapse state, and any workbench.editorAssociations pinned to the
old viewType.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The command palette showed "dbt: Create Domain" and all internal identifiers still used the pre-rename
dbtSemanticscheme. This renames everything to the ERD Studio brand:"dbt"→"ERD Studio"(all 16 commands)dbtSemantic.*→erdStudio.*; activity bar containerdbt-semantic→erd-studiodbtSemantic.projectPath/dbtSemantic.semanticDir→erdStudio.*(Settings UI now groups under "ERD Studio")dbt-semantic-layer→erd-studio-layerBackward compatibility for existing users
dbtSemantic.*command ID stays registered in code as a hidden delegate to itserdStudio.*counterpart (LEGACY_ALIASED_COMMANDSinextension.ts) — old keybindings keep working, palette stays cleangetErdStudioSetting()helper resolves expliciterdStudio.*values first, then explicitdbtSemantic.*values, then the default — users with the old keys configured lose nothing. Old keys remain contributed with deprecation messages pointing to the new onesworkbench.editorAssociationsmanually pinned todbtSemantic.domainEditor(rare; falls back to the default editor association)Notes: the
dbtSemantic.layer.*color contributions were dead (nothing referenced them in src/ or webview/) — renamed rather than removed. No harness content changes, so noHARNESS_VERSIONbump.Test plan
npm run compile,npm run build, full suite 377/377 passingpackage.jsonparses; viewsWelcome command links, menus, and when-clauses all point aterdStudio.*dbtSemantic.*keybinding still fires🤖 Generated with Claude Code