feat(identity): allow importing and exporting secp256k1 keys#3887
Merged
Conversation
drHuangMHT
changed the title
Contributor
Author
|
Getting the public key of the test key is a real pain in the A. |
thomaseizinger
approved these changes
May 5, 2023
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thank you!
I've verified that the test vector is the same the nim-libp2p uses here: https://github.com/status-im/nim-libp2p/blob/a1eb53b1813df5d4fa1b343ef003ad9fb5ebb1d8/tests/testpeerid.nim#LL162C6-L162C6
They generated it using go-libp2ps tools so I am quite confident that this works as expected. I added the test vector we are using to the open libp2p/specs PR: libp2p/specs@0e0ced7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #3681
Notes & open questions
Change checklist