Open
Conversation
added 19 commits
February 15, 2024 08:38
…ens to help with hacks.
…o account once it hits fuzzy matching.
…he correct console. Gonna undo some of this and try again with a more simple setup.
Open
Contributor
Author
|
I'm not sure why it's complaining about apt on those two builds, they worked on the previous one and those commands haven't changed. Hopefully something temporary on the github side of the VMs. |
igorcafe
reviewed
Mar 1, 2024
| mu sync.Mutex | ||
| found bool | ||
| } | ||
| game_found := SafeBool{found: false} |
Contributor
There was a problem hiding this comment.
Didn't analyze it deeply, but do you really need a mutex or a atomic.Bool fits your needs?
igorcafe
reviewed
Mar 1, 2024
| game_found.mu.Unlock() | ||
| } else { | ||
| var gameName = strings.Split(romName, ".")[0] | ||
| var gameExt = strings.Split(romName, ".")[1] |
Contributor
There was a problem hiding this comment.
I believe the file may contain multiple dots or even no dots.
I guess you could use filepath.Ext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds fuzzy search to ludo via a few mechanisms.
FindByCRCnow fails through toFindByROMNameFindByROMNameis now tried again with increasingly stripped titles until failureThis branch also includes the same fixes as #521 and addresses #453