fix(gui): dialog overlay frame and sticky Sub-agent focus ring#154
Closed
Wibias wants to merge 1 commit into
Closed
fix(gui): dialog overlay frame and sticky Sub-agent focus ring#154Wibias wants to merge 1 commit into
Wibias wants to merge 1 commit into
Conversation
Reset dialog.modal-overlay UA border/backdrop that framed log details, and restore opener focus without focus-visible after Sub-agent help closes.
lidge-jun
added a commit
that referenced
this pull request
Jul 19, 2026
Repair for community PR #154 absorb (source head 5e8f1aa), Sol review findings: - Track the last input modality window-wide (keydown vs pointerdown, capture phase). focusTriggerQuietly now suppresses :focus-visible ONLY for pointer-originated closes; Escape/Enter/Space closes restore plain focus so keyboard users keep their location indicator. - The focusVisible option (Chrome 145+/FF 104+/Safari 18.4+) remains a progressive enhancement: engines that ignore it keep pre-repair behavior, and the origin tracking makes keyboard closes correct everywhere. Render-grounded: dev GUI driven in Chrome — overlay shows no white UA frame or double dim; pointer close leaves no ring; Escape close paints the visible focus ring on the Sub-agent info trigger. Co-authored-by: Wibias <37517432+Wibias@users.noreply.github.com>
Owner
|
Thanks — the white UA frame + double-dim diagnosis was exactly right, and it's landed on
Render-verified in the browser: overlay clean, mouse close leaves no ring, Escape close paints the visible ring. Closing in favor of the dev-landed commits; ships with the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<dialog class="modal-overlay">. Browser UA styles still draw a solid border plus a separate::backdrop, which stacked on our full-screen tint and produced the white rectangular frame / double-dimmed background around the error modal.:focus-visible, so the focus ring stacked on the icon’s own circle (sticky double ring until you clicked elsewhere). Restore now usesfocus({ focusVisible: false })so keyboard a11y focus return stays, without the leftover mouse-close ring.Screenshots
Test plan