fix(windows): hide icacls during secret ACL hardening#155
Closed
Wibias wants to merge 1 commit into
Closed
Conversation
Spawning icacls without windowsHide from the GUI/proxy can hang until the 5s timeout (ETIMEDOUT), blocking Kimi and other OAuth logins that write auth.json.
Contributor
Author
|
Closing as duplicate — same icacls windowsHide fix already lands in #152. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACL hardening failed (ETIMEDOUT)because writingauth.jsonrunsicaclswith a 5s timeout.icacls.exewithoutwindowsHide: truefrom the GUI/proxy process can hang until that timeout.windowsHide: trueto the three ACL hardeningicaclscalls so OAuth login can finish.Test plan
bun test tests/windows-secret-acl.test.ts