fix(lpa-link): declare required-features for manage_smoke example#115
Open
Yona-Appletree wants to merge 1 commit into
Open
fix(lpa-link): declare required-features for manage_smoke example#115Yona-Appletree wants to merge 1 commit into
Yona-Appletree wants to merge 1 commit into
Conversation
The manage_smoke example imports DeviceTimers and the host_serial_esp32 provider, both gated behind the host-serial-esp32 feature chain, but Cargo.toml had no [[example]] entry saying so. As a result `cargo test -p lpa-link` and `cargo build -p lpa-link --examples` failed to compile on a clean tree with E0432/E0599; workspace-level builds only passed via feature unification from sibling crates. Declare the example with required-features = ["host-serial-esp32"] so default-feature builds skip it and feature-enabled builds still compile it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
[[example]]entry tolp-app/lpa-link/Cargo.tomldeclaringrequired-features = ["host-serial-esp32"]for themanage_smokeexample.Why
manage_smoke.rsimportsDeviceTimers/DeviceSession(gated behinddevice-session) and theproviders::host_serial_esp32module, but nothing in the manifest declared that dependency. On a clean tree,cargo test -p lpa-linkandcargo build -p lpa-link --examplesfailed to compile with E0432/E0599. Workspace-levelcargo testonly passed because feature unification from sibling crates happened to enable the features.host-serial-esp32is the minimal feature set: it impliesdevice-session-host→device-session, covering everything the example uses.Verification
cargo build -p lpa-link --examples(default features): now a clean no-op — the example is correctly skipped.cargo test -p lpa-link: 8 passed, 0 failed.cargo build -p lpa-link --example manage_smoke --features host-serial-esp32: still builds.🤖 Generated with Claude Code