Bring back a couple of configs and classes#446
Merged
Conversation
…HTTP < v2 and Akka HTTP <= v10.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I cleaned up ssl-config, turns out that Akka <= v2.8 (and therefore also Pekko < v2) does use some configs and classes that are not even used by ssl-config itself, which was the reason I removed them. However when upgrading to ssl-config v0.7.0 apps that rely on Pekko < v2 and Akka <= v2.8 would break...
So I brought those required classes and configs back. So next v0.7.1 release should finally be a drop in replacement for Akka and Pekko.
Tested locally with akka, akka-http, pekko, pekko-http, gigahorse etc.
I hope that is it for now.