Skip to content

Enable Creation of Offers and Refunds Without Blinded Path #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 11 commits into from
Jul 24, 2025

Test: Add coverage for Offers and Refunds without blinded paths

596cf47
Select commit
Loading
Failed to load commit list.
Merged

Enable Creation of Offers and Refunds Without Blinded Path #3246

Test: Add coverage for Offers and Refunds without blinded paths
596cf47
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 24, 2025 in 0s

88.95% (+0.01%) compared to ebe571a

View this Pull Request on Codecov

88.95% (+0.01%) compared to ebe571a

Details

Codecov Report

Attention: Patch coverage is 96.10028% with 14 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (ebe571a) to head (596cf47).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/onion_message/messenger.rs 84.84% 5 Missing ⚠️
lightning/src/ln/channelmanager.rs 90.62% 2 Missing and 1 partial ⚠️
lightning/src/ln/offers_tests.rs 98.01% 1 Missing and 1 partial ⚠️
lightning/src/util/test_utils.rs 94.44% 2 Missing ⚠️
lightning-dns-resolver/src/lib.rs 66.66% 1 Missing ⚠️
lightning/src/offers/flow.rs 98.98% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
+ Coverage   88.93%   88.95%   +0.01%     
==========================================
  Files         168      173       +5     
  Lines      121962   123516    +1554     
  Branches   121962   123516    +1554     
==========================================
+ Hits       108471   109870    +1399     
- Misses      11088    11194     +106     
- Partials     2403     2452      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov