Skip to content

[Splicing] Tx negotiation during splicing #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpaulino merged 9 commits into from
Jul 31, 2025

Clear interactive_tx_signing_session upon splice promotion

41cbc1f
Select commit
Loading
Failed to load commit list.
Merged

[Splicing] Tx negotiation during splicing #3736

Clear interactive_tx_signing_session upon splice promotion
41cbc1f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 31, 2025 in 1s

88.95% (+0.02%) compared to 7ec13dc

View this Pull Request on Codecov

88.95% (+0.02%) compared to 7ec13dc

Details

Codecov Report

❌ Patch coverage is 67.36111% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.95%. Comparing base (7ec13dc) to head (41cbc1f).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 59.83% 49 Missing ⚠️
lightning/src/ln/channelmanager.rs 33.33% 32 Missing and 6 partials ⚠️
lightning/src/ln/interactivetxs.rs 93.57% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
+ Coverage   88.92%   88.95%   +0.02%     
==========================================
  Files         174      174              
  Lines      123869   124200     +331     
  Branches   123869   124200     +331     
==========================================
+ Hits       110152   110476     +324     
+ Misses      11256    11247       -9     
- Partials     2461     2477      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov