Skip to content

Async send: sender-side #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 14 commits into from
Sep 19, 2025

Test async send

9e30591
Select commit
Loading
Failed to load commit list.
Merged

Async send: sender-side #4046

Test async send
9e30591
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 18, 2025 in 0s

88.69% (+0.09%) compared to cd85a80

View this Pull Request on Codecov

88.69% (+0.09%) compared to cd85a80

Details

Codecov Report

❌ Patch coverage is 92.69283% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.69%. Comparing base (cd85a80) to head (9e30591).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/async_payments_tests.rs 96.26% 13 Missing and 7 partials ⚠️
lightning/src/ln/channelmanager.rs 80.00% 15 Missing and 2 partials ⚠️
lightning/src/ln/channel.rs 87.71% 5 Missing and 2 partials ⚠️
lightning/src/ln/functional_test_utils.rs 73.33% 3 Missing and 1 partial ⚠️
lightning/src/offers/flow.rs 78.94% 3 Missing and 1 partial ⚠️
lightning/src/util/config.rs 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
+ Coverage   88.60%   88.69%   +0.09%     
==========================================
  Files         176      176              
  Lines      132070   132728     +658     
  Branches   132070   132728     +658     
==========================================
+ Hits       117015   117726     +711     
+ Misses      12386    12324      -62     
- Partials     2669     2678       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov