Skip to content

lightning-liquidity: Add serialization logic, persist service state #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 21 commits into from
Sep 24, 2025

Log `PublicKey`s as `Display`, not `Debug`

adc8a87
Select commit
Loading
Failed to load commit list.
Merged

lightning-liquidity: Add serialization logic, persist service state #4059

Log `PublicKey`s as `Display`, not `Debug`
adc8a87
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2025 in 0s

88.48% (-0.27%) compared to 32314e3

View this Pull Request on Codecov

88.48% (-0.27%) compared to 32314e3

Details

Codecov Report

❌ Patch coverage is 62.23565% with 375 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.48%. Comparing base (32314e3) to head (adc8a87).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
lightning-liquidity/src/lsps2/service.rs 47.50% 145 Missing and 13 partials ⚠️
lightning-liquidity/src/manager.rs 72.03% 60 Missing and 6 partials ⚠️
lightning-liquidity/src/events/event_queue.rs 59.85% 50 Missing and 5 partials ⚠️
lightning-liquidity/src/lsps5/service.rs 70.32% 20 Missing and 7 partials ⚠️
lightning-liquidity/src/persist.rs 71.26% 16 Missing and 9 partials ⚠️
lightning-liquidity/src/lsps0/ser.rs 53.57% 10 Missing and 3 partials ⚠️
lightning-background-processor/src/lib.rs 76.59% 8 Missing and 3 partials ⚠️
lightning-liquidity/src/lsps2/client.rs 15.38% 11 Missing ⚠️
lightning-liquidity/src/lsps1/client.rs 0.00% 5 Missing ⚠️
lightning-liquidity/src/lsps0/client.rs 85.71% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4059      +/-   ##
==========================================
- Coverage   88.75%   88.48%   -0.27%     
==========================================
  Files         177      179       +2     
  Lines      133318   134111     +793     
  Branches   133318   134111     +793     
==========================================
+ Hits       118330   118674     +344     
- Misses      12293    12683     +390     
- Partials     2695     2754      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov