Skip to content

Add support for native async KVStore persist to ChainMonitor #4063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 14 commits into from
Sep 23, 2025

Add a test for the new async `ChainMonitor` operation

462a647
Select commit
Loading
Failed to load commit list.
Merged

Add support for native async KVStore persist to ChainMonitor #4063

Add a test for the new async `ChainMonitor` operation
462a647
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 22, 2025 in 1s

88.72% (+0.01%) compared to 1ed6c4b

View this Pull Request on Codecov

88.72% (+0.01%) compared to 1ed6c4b

Details

Codecov Report

❌ Patch coverage is 85.38588% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.72%. Comparing base (1ed6c4b) to head (462a647).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/persist.rs 79.72% 45 Missing and 15 partials ⚠️
lightning/src/util/test_utils.rs 81.31% 13 Missing and 4 partials ⚠️
lightning/src/util/native_async.rs 81.48% 5 Missing ⚠️
lightning/src/ln/chanmon_update_fail_tests.rs 97.24% 1 Missing and 3 partials ⚠️
lightning/src/chain/chainmonitor.rs 94.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4063      +/-   ##
==========================================
+ Coverage   88.71%   88.72%   +0.01%     
==========================================
  Files         176      177       +1     
  Lines      132778   133252     +474     
  Branches   132778   133252     +474     
==========================================
+ Hits       117790   118234     +444     
- Misses      12304    12320      +16     
- Partials     2684     2698      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov