deps: bump electron stack and resolve all 22 npm audit findings#145
deps: bump electron stack and resolve all 22 npm audit findings#145kairoxxai wants to merge 1 commit into
Conversation
- electron 33.3.0 → 42.0.1 - electron-builder 24.13.3 → 26.8.1 - electron-vite 2.3.0 → 5.0.0 - vite 5.4.0 → 8.0.12 Closes 22 npm audit findings (12 high, 6 moderate, 4 low) including node-tar path traversal (multiple GHSAs), postcss XSS, and esbuild/vite transitive vulns. Build verified clean across all three electron-vite environments (main, preload, renderer). App launches and exercises Python bridge + three.js renderer successfully. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Can you merge it into the dev branch? Thanks |
|
Hi @kairoxxai — thanks again for tackling this, the security goal is exactly right. 🙏 I tested the branch in an isolated worktree before merging and hit a few things worth fixing; sharing them so you can keep ownership of the PR:
What I'd suggest changing, and why:
|
Summary
Closes all 22
npm auditfindings (12 high, 6 moderate, 4 low) by bumping the electron build stack:Notable advisories closed: node-tar path traversal (multiple GHSAs), postcss XSS (
GHSA-qx2v-qp2m-jg93), and a long tail of esbuild/vite transitive vulns.Test plan
npm auditreports 0 vulnerabilities post-upgradenpm run buildcompletes cleanly across all three electron-vite environments (main, preload, renderer)npm run devlaunches the Electron app on Linux (Pop OS 24.04, Wayland); Python bridge boots, registry initializes, three.js renderer loadsNotes
esbuildplugin option,optimizeDeps.rollupOptions,plugin-react→plugin-react-oxc). All non-fatal — flagged for a future cleanup PR.eslintrc.*config will need migration toeslint.config.js(out of scope here;npm run lintwas already broken before this PR)