Skip to content

Make umaAddress optional in create user endpoint #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pengying wants to merge 1 commit into from
+0 −1
Closed

Make umaAddress optional in create user endpoint #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion openapi/components/schemas/users/User.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
type: object
required:
- umaAddress
- platformUserId
- userType
Comment on lines 2 to 4
Copy link
Copy Markdown

@greptile-apps greptile-apps bot Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Response schema also marks umaAddress as optional

User.yaml is used for both the POST /users request body and the 201 response (via IndividualUser.yaml / BusinessUser.yaml). Removing umaAddress from required here means the 201 response schema now also declares it optional. If the system always returns an auto-generated address in the response, the response schema should still mark it required — otherwise generated clients will defensively treat umaAddress as potentially absent from every response.

Consider splitting into separate request/response schemas (e.g. CreateUserRequest.yaml with umaAddress optional, and the existing User.yaml keeping umaAddress required in required), or at minimum add a note in the response schema that umaAddress is always populated.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/users/User.yaml
Line: 2-4

Comment:
**Response schema also marks `umaAddress` as optional**

`User.yaml` is used for both the `POST /users` request body and the `201` response (via `IndividualUser.yaml` / `BusinessUser.yaml`). Removing `umaAddress` from `required` here means the 201 response schema now also declares it optional. If the system always returns an auto-generated address in the response, the response schema should still mark it required — otherwise generated clients will defensively treat `umaAddress` as potentially absent from every response.

Consider splitting into separate request/response schemas (e.g. `CreateUserRequest.yaml` with `umaAddress` optional, and the existing `User.yaml` keeping `umaAddress` required in `required`), or at minimum add a note in the response schema that `umaAddress` is always populated.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

properties:
Expand Down