feat: support Symfony 8.1+ runCommand via conditional class aliasing#676
Merged
alexisLefebvre merged 3 commits intoJun 24, 2026
Merged
Conversation
alexisLefebvre
force-pushed
the
fix/symfony-8.1-run-command-compat
branch
3 times, most recently
from
9b65a63 to
dcf9092
Compare
- Created LegacyWebTestCase and ModernWebTestCase to house version-compatible runCommand signatures. - Configured dynamic class aliasing in WebTestCase based on Kernel::VERSION. - Added active instance tracking to WebTestCase to support static context delegation. - Updated command tests to support both CommandTester and ExecutionResult. Co-authored-by: Gemini 3.5 Flash <218195315+gemini-cli@users.noreply.github.com>
- Checked Symfony version using Kernel::VERSION in test assertions rather than class_exists(ExecutionResult::class). - Applied php-cs-fixer style fixes to WebTestCase.php. Co-authored-by: Gemini 3.5 Flash <218195315+gemini-cli@users.noreply.github.com>
…rnel::VERSION check Co-authored-by: Gemini 3.5 Flash <218195315+gemini-cli@users.noreply.github.com>
alexisLefebvre
force-pushed
the
fix/symfony-8.1-run-command-compat
branch
from
dcf9092 to
10e3fab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with Symfony 8.1's new
runCommand()method returningExecutionResult.Changes:
LegacyWebTestCaseandModernWebTestCaseto declare correct version-specific signatures forrunCommand().WebTestCaseusing robust feature detection (method_exists()) to check if the parent class hasrunCommand().WebTestCase::$activeInstancetracking.CommandTesterandExecutionResulttransparently using directinstanceofchecks.php-cs-fixerto clean up unused imports and apply styling fixes.Fix issue from:
🤖 Generated with Antigravity (Gemini 3.5 Flash)