Fix crash: v can not be null after view is destroyed#101
Open
limedroid wants to merge 1 commit into
Open
Conversation
When a network request completes after Activity/Fragment destruction,
getV() threw IllegalStateException ("v can not be null"). Return null
from getV() when the view is detached, fix detachV() null-safety, and
guard async presenter callbacks with hasV() checks.
Co-authored-by: WangLei <limedroid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user starts an async network request and leaves the screen before it completes, the presenter callback still calls
getV(). AfteronDestroy/onDestroyView, the view has already been detached, sogetV()threw:This is a common crash reported in issues #71, #77, and #82.
Solution
XPresent:getV()now returnsnullwhen the view is detached instead of throwing.detachV()also checksv != nullbefore clearing the weak reference.PBasePager: AsynconNext/onFailcallbacks guard view access withhasV()before updating the UI.PMulti: SamehasV()guard for consistency.Notes
Presenter code that calls
getV()should checkhasV()(or null-check the return value) in async callbacks to avoid updating a destroyed view.