Skip to content

[WIP] Can we use a simplier version of SetChildValue? #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] Can we use a simplier version of SetChildValue? #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
020e981
Initial commit with task details for issue #126
konard Sep 13, 2025
f57840f
'Auto-commit changes made by Claude
konard Sep 13, 2025
b569d57
Remove CLAUDE.md - Claude command completed
konard Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csharp/Platform.Collections/Trees/Node.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public Node SetChildValue(object value, params object[] keys)
var node = this;
for (var i = 0; i < keys.Length; i++)
{
node = SetChildValue(value, keys[i]);
node = node[keys[i]];
}
node.Value = value;
return node;
Expand Down
38 changes: 38 additions & 0 deletions experiments/TestCurrentBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
using System;
using Platform.Collections.Trees;

namespace Experiments
{
class Program
{
static void Main(string[] args)
{
Console.WriteLine("Testing current SetChildValue behavior...");

var root = new Node();

// Test setting value with multiple keys
root.SetChildValue("FinalValue", "key1", "key2", "key3");

// Check values at each level
Console.WriteLine($"Root value: {root.Value}");
Console.WriteLine($"Level 1 (key1) value: {root.GetChildValue("key1")}");
Console.WriteLine($"Level 2 (key1->key2) value: {root.GetChildValue("key1", "key2")}");
Console.WriteLine($"Level 3 (key1->key2->key3) value: {root.GetChildValue("key1", "key2", "key3")}");

Console.WriteLine();
Console.WriteLine("What we EXPECT:");
Console.WriteLine("Root value: null");
Console.WriteLine("Level 1 (key1) value: null");
Console.WriteLine("Level 2 (key1->key2) value: null");
Console.WriteLine("Level 3 (key1->key2->key3) value: FinalValue");

Console.WriteLine();
Console.WriteLine("What we ACTUALLY GET:");
Console.WriteLine("Root value: " + (root.Value ?? "null"));
Console.WriteLine("Level 1 (key1) value: " + (root.GetChildValue("key1") ?? "null"));
Console.WriteLine("Level 2 (key1->key2) value: " + (root.GetChildValue("key1", "key2") ?? "null"));
Console.WriteLine("Level 3 (key1->key2->key3) value: " + (root.GetChildValue("key1", "key2", "key3") ?? "null"));
}
}
}
14 changes: 14 additions & 0 deletions experiments/TestCurrentBehavior.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\csharp\Platform.Collections\Platform.Collections.csproj" />
</ItemGroup>

</Project>
43 changes: 43 additions & 0 deletions experiments/TestFixedBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
using System;
using Platform.Collections.Trees;

namespace Experiments
{
class FixedBehaviorTest
{
static void Main(string[] args)
{
Console.WriteLine("Testing FIXED SetChildValue behavior...");

var root = new Node();

// Test setting value with multiple keys
root.SetChildValue("FinalValue", "key1", "key2", "key3");

// Check values at each level
Console.WriteLine($"Root value: {root.Value ?? "null"}");
Console.WriteLine($"Level 1 (key1) value: {root.GetChildValue("key1") ?? "null"}");
Console.WriteLine($"Level 2 (key1->key2) value: {root.GetChildValue("key1", "key2") ?? "null"}");
Console.WriteLine($"Level 3 (key1->key2->key3) value: {root.GetChildValue("key1", "key2", "key3") ?? "null"}");

Console.WriteLine();
Console.WriteLine("EXPECTED vs ACTUAL:");
Console.WriteLine($"Root value: null -> {root.Value ?? "null"} {(root.Value == null ? "✓" : "✗")}");
Console.WriteLine($"Level 1 (key1) value: null -> {root.GetChildValue("key1") ?? "null"} {(root.GetChildValue("key1") == null ? "✓" : "✗")}");
Console.WriteLine($"Level 2 (key1->key2) value: null -> {root.GetChildValue("key1", "key2") ?? "null"} {(root.GetChildValue("key1", "key2") == null ? "✓" : "✗")}");
Console.WriteLine($"Level 3 (key1->key2->key3) value: FinalValue -> {root.GetChildValue("key1", "key2", "key3") ?? "null"} {(root.GetChildValue("key1", "key2", "key3")?.ToString() == "FinalValue" ? "✓" : "✗")}");

Console.WriteLine();
Console.WriteLine("Additional test - setting different values at different paths:");
root.SetChildValue("Value1", "a");
root.SetChildValue("Value2", "a", "b");
root.SetChildValue("Value3", "x", "y", "z");

Console.WriteLine($"Path 'a' value: {root.GetChildValue("a") ?? "null"} (expected: Value1)");
Console.WriteLine($"Path 'a' -> 'b' value: {root.GetChildValue("a", "b") ?? "null"} (expected: Value2)");
Console.WriteLine($"Path 'x' -> 'y' -> 'z' value: {root.GetChildValue("x", "y", "z") ?? "null"} (expected: Value3)");
Console.WriteLine($"Path 'x' value: {root.GetChildValue("x") ?? "null"} (expected: null)");
Console.WriteLine($"Path 'x' -> 'y' value: {root.GetChildValue("x", "y") ?? "null"} (expected: null)");
}
}
}
14 changes: 14 additions & 0 deletions experiments/TestFixedBehavior.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\csharp\Platform.Collections\Platform.Collections.csproj" />
</ItemGroup>

</Project>
43 changes: 43 additions & 0 deletions test_fixed/TestFixedBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
using System;
using Platform.Collections.Trees;

namespace Experiments
{
class FixedBehaviorTest
{
static void Main(string[] args)
{
Console.WriteLine("Testing FIXED SetChildValue behavior...");

var root = new Node();

// Test setting value with multiple keys
root.SetChildValue("FinalValue", "key1", "key2", "key3");

// Check values at each level
Console.WriteLine($"Root value: {root.Value ?? "null"}");
Console.WriteLine($"Level 1 (key1) value: {root.GetChildValue("key1") ?? "null"}");
Console.WriteLine($"Level 2 (key1->key2) value: {root.GetChildValue("key1", "key2") ?? "null"}");
Console.WriteLine($"Level 3 (key1->key2->key3) value: {root.GetChildValue("key1", "key2", "key3") ?? "null"}");

Console.WriteLine();
Console.WriteLine("EXPECTED vs ACTUAL:");
Console.WriteLine($"Root value: null -> {root.Value ?? "null"} {(root.Value == null ? "✓" : "✗")}");
Console.WriteLine($"Level 1 (key1) value: null -> {root.GetChildValue("key1") ?? "null"} {(root.GetChildValue("key1") == null ? "✓" : "✗")}");
Console.WriteLine($"Level 2 (key1->key2) value: null -> {root.GetChildValue("key1", "key2") ?? "null"} {(root.GetChildValue("key1", "key2") == null ? "✓" : "✗")}");
Console.WriteLine($"Level 3 (key1->key2->key3) value: FinalValue -> {root.GetChildValue("key1", "key2", "key3") ?? "null"} {(root.GetChildValue("key1", "key2", "key3")?.ToString() == "FinalValue" ? "✓" : "✗")}");

Console.WriteLine();
Console.WriteLine("Additional test - setting different values at different paths:");
root.SetChildValue("Value1", "a");
root.SetChildValue("Value2", "a", "b");
root.SetChildValue("Value3", "x", "y", "z");

Console.WriteLine($"Path 'a' value: {root.GetChildValue("a") ?? "null"} (expected: Value1)");
Console.WriteLine($"Path 'a' -> 'b' value: {root.GetChildValue("a", "b") ?? "null"} (expected: Value2)");
Console.WriteLine($"Path 'x' -> 'y' -> 'z' value: {root.GetChildValue("x", "y", "z") ?? "null"} (expected: Value3)");
Console.WriteLine($"Path 'x' value: {root.GetChildValue("x") ?? "null"} (expected: null)");
Console.WriteLine($"Path 'x' -> 'y' value: {root.GetChildValue("x", "y") ?? "null"} (expected: null)");
}
}
}
14 changes: 14 additions & 0 deletions test_fixed/TestFixedBehavior.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8</TargetFramework>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\csharp\Platform.Collections\Platform.Collections.csproj" />
</ItemGroup>

</Project>
Loading