Integration tests for support Linode integration with alerts by psnoch-akamai · Pull Request #669 · linode/linode_api4-python

psnoch-akamai · 2026-03-17T19:05:40Z

📝 Description

Integration tests for support Linode integration with alerts

✔️ How to Test

make TEST_CASE=test_get_linodes_verify_alerts test-int
make TEST_CASE=test_linode_rebuild test-int
make TEST_CASE=test_linode_alerts_workflow test-int
make TEST_CASE=test_try_to_update_linode_alerts_legacy_and_aclp_at_the_same_time test-int

Copilot

Pull request overview

Adds integration test coverage for Linode Instance “alerts” behavior in the Python SDK, focusing on listing, rebuilding, updating, cloning, and validating error behavior when mixing legacy and ACLP alerts.

Changes:

Add a new integration test to verify alerts are present when listing Linodes.
Extend the rebuild integration test to assert alerts fields are populated.
Add workflow/error-path integration tests for updating alerts and validating legacy vs ACLP alert incompatibilities.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/integration/models/linode/test_linode.py

yec-akamai · 2026-03-30T19:58:42Z

test/integration/models/linode/test_linode.py

    return type in str(linode.type)


+def test_get_linodes_verify_alerts(test_linode_client, create_linode):


create_linode is not used in this test. Probably can be removed.

Correct, but we need at least one linode to verify get linodes endpoint. It was suggested by copilot #669 (comment). What do you think about this?

The copilot suggests to not use the listing endpoint linode.instance() and use create_linode. I agree that it's safer to not assume there is linode available by listing.

yec-akamai · 2026-03-30T20:01:10Z

test/integration/models/linode/test_linode.py

+        new_linode.delete()
+
+
+def test_try_to_update_linode_alerts_legacy_and_aclp_at_the_same_time(


We can consider not testing this case, because this behavior will be removed in a following api change. I will send the doc to you.

yec-akamai · 2026-03-30T20:06:03Z

test/integration/models/linode/test_linode.py

    assert linode.status == "running"


+def test_linode_alerts_workflow(test_linode_client, create_linode):


Can we add a test case to creat linode with aclp alerts? Adding system_alerts should be good

Good point, please verify test just added: test_update_linode_aclp_alerts

Copilot

Pull request overview

Adds integration coverage to validate Linode “alerts” behavior is present and consistent across common instance operations in the SDK’s integration test suite.

Changes:

Add an instances-list test that asserts alerts fields are present and non-negative.
Extend the rebuild integration test to assert alerts are accessible during rebuild.
Add workflow tests for reading/updating alerts, cloning behavior, and an error case when mixing legacy + ACLP alerts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-31T13:53:55Z

test/integration/models/linode/test_linode.py

+    linodes_list = test_linode_client.linode.instances().lists[0]
+    assert len(linodes_list) > 0
+    assert linodes_list[0].alerts.cpu >= 0
+    assert linodes_list[0].alerts.io >= 0
+    assert linodes_list[0].alerts.network_in >= 0
+    assert linodes_list[0].alerts.network_out >= 0
+    assert linodes_list[0].alerts.transfer_quota >= 0
+
+


test_get_linodes_verify_alerts is non-deterministic: it creates a Linode via the create_linode fixture but then asserts against instances().lists[0][0], which may be an unrelated instance (ordering/pagination is not guaranteed). To make the test reliable, assert against the specific Linode created by the fixture (e.g., load by create_linode.id or filter the list for that ID), and avoid reaching into the internal .lists cache when plain indexing/iteration works.

Suggested change

linodes_list = test_linode_client.linode.instances().lists[0]

assert len(linodes_list) > 0

assert linodes_list[0].alerts.cpu >= 0

assert linodes_list[0].alerts.io >= 0

assert linodes_list[0].alerts.network_in >= 0

assert linodes_list[0].alerts.network_out >= 0

assert linodes_list[0].alerts.transfer_quota >= 0

linode = test_linode_client.load(Instance, create_linode.id)

assert linode.alerts.cpu >= 0

assert linode.alerts.io >= 0

assert linode.alerts.network_in >= 0

assert linode.alerts.network_out >= 0

assert linode.alerts.transfer_quota >= 0

Copilot · 2026-03-31T13:53:55Z

test/integration/models/linode/test_linode.py

+    linode.alerts = {
+        "cpu": 50,
+        "io": 6000,
+        "network_in": 20,
+        "network_out": 20,
+        "transfer_quota": 40,
+    }
+    linode.save()
+
+    wait_for_condition(10, 100, get_status, linode, "running")
+    new_linode = retry_sending_request(
+        5,
+        linode.clone,
+        region=linode.region.id,
+        instance_type=linode.type.id,
+        label=get_test_label(),
+    )
+    assert new_linode.alerts.cpu == 90
+    assert new_linode.alerts.io == 10000
+    assert new_linode.alerts.network_in == 10
+    assert new_linode.alerts.network_out == 10
+    assert new_linode.alerts.transfer_quota == 80
+    assert isinstance(new_linode.alerts.system_alerts, list)
+    assert isinstance(new_linode.alerts.user_alerts, list)


In test_linode_alerts_workflow, the test updates linode.alerts (cpu/io/network_*/transfer_quota) and calls linode.save(), but none of the subsequent assertions check that the update actually took effect. As written, the test would still pass even if the save was a no-op, which weakens the intended coverage. Consider asserting the saved values after a reload, and then align the clone assertions with the intended behavior (either the clone inherits the updated alerts, or it resets to defaults—right now it asserts the same default values as before the update).

Copilot · 2026-03-31T13:53:55Z

test/integration/models/linode/test_linode.py

+    if new_linode is not None:
+        new_linode.delete()


if new_linode is not None: is redundant here: the test already dereferences new_linode.alerts.* above, so new_linode must be non-None for the test to reach the cleanup. Prefer unconditional deletion (or a try/finally around assertions) to make the cleanup intent clearer.

Suggested change

if new_linode is not None:

new_linode.delete()

new_linode.delete()

…ame_time and add test test_update_linode_aclp_alerts

Create tests for Linode integration with alerts

2736865

psnoch-akamai requested a review from a team as a code owner March 17, 2026 19:05

psnoch-akamai requested review from ezilber-akamai and mawilk90 and removed request for a team March 17, 2026 19:05

psnoch-akamai changed the base branch from dev to proj/aclp-linode-alerts March 17, 2026 19:08

psnoch-akamai requested review from Copilot and yec-akamai March 17, 2026 19:09

Copilot started reviewing on behalf of psnoch-akamai March 17, 2026 19:10 View session

psnoch-akamai added the testing for updates to the testing suite in the changelog. label Mar 17, 2026

Copilot AI reviewed Mar 17, 2026

View reviewed changes

psnoch-akamai marked this pull request as draft March 19, 2026 13:07

psnoch-akamai changed the title ~~Tpt 4269 python sdk qa support linode integration with alerts~~ Integration tests for support Linode integration with alerts Mar 19, 2026

Code review fixes

e256458

psnoch-akamai marked this pull request as ready for review March 30, 2026 17:17

yec-akamai reviewed Mar 30, 2026

View reviewed changes

yec-akamai requested a review from Copilot March 31, 2026 13:49

Copilot started reviewing on behalf of yec-akamai March 31, 2026 13:49 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Remove test test_try_to_update_linode_alerts_legacy_and_aclp_at_the_s…

2ca53cc

…ame_time and add test test_update_linode_aclp_alerts

		return type in str(linode.type)


		def test_get_linodes_verify_alerts(test_linode_client, create_linode):

		new_linode.delete()


		def test_try_to_update_linode_alerts_legacy_and_aclp_at_the_same_time(

		assert linode.status == "running"


		def test_linode_alerts_workflow(test_linode_client, create_linode):

	if new_linode is not None:
	new_linode.delete()
	new_linode.delete()

Conversation

psnoch-akamai commented Mar 17, 2026

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yec-akamai Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yec-akamai Mar 31, 2026 •

edited

Loading