Skip to content

chore: Update version to 6.5.28#412

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
dengzhongyuan365-dev:fix-4-30
May 14, 2026
Merged

chore: Update version to 6.5.28#412
lzwind merged 1 commit into
linuxdeepin:masterfrom
dengzhongyuan365-dev:fix-4-30

Conversation

@dengzhongyuan365-dev
Copy link
Copy Markdown
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented May 14, 2026

  • update version to 6.5.28

log: update version to 6.5.28

Summary by Sourcery

Chores:

  • Bump Debian package changelog to version 6.5.28.

- update version to 6.5.28

log: update version to 6.5.28
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the Debian package version reference to 6.5.28 in the changelog to prepare a new release.

File-Level Changes

Change Details Files
Update Debian changelog entry to version 6.5.28.
  • Adjust the topmost changelog entry to use version 6.5.28.
  • Refresh any associated log/message text in the changelog to reflect the new version number.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.5.28
EXISTED: no
DISTRIBUTION: unstable

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit bc0a7fb into linuxdeepin:master May 14, 2026
16 of 17 checks passed
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX,你的智能编程助手。

针对你提供的 git diff 输入,我进行了仔细的审查。本次提交主要修改了 Debian 打包的变更日志(debian/changelog),记录了修复 ZIP 多卷压缩在引入 pzip 插件后失效的问题。

由于本次变更仅涉及包管理元数据,不包含实际的业务代码逻辑,因此不存在语法逻辑、代码性能和代码安全方面的问题。但我对代码质量(规范合规性)和项目维护方面有以下的审查意见和改进建议:

1. 代码质量(规范合规性)

Debian 的 changelog 有着严格的格式要求(由 debcontrol 规范定义),任何格式错误都可能导致打包失败。

  • 日期格式问题(潜在风险)
    你使用的日期是 Thu, 14 May 2026 19:02:25 +0800。虽然这符合 RFC 2822 格式,但年份是 2026 年,这显然是系统时间设置错误或手动修改时的笔误。

    • 风险:如果系统时钟不正确,dpkg 在打包时可能会因为时间戳异常(如远超当前时间)产生不可预期的行为,或者在软件源中显示异常。
    • 改进建议:请确保日期为实际提交时间。推荐使用 dch -idebchange 命令自动生成条目,它会自动获取正确的当前系统时间,避免手动输入错误。
  • 版本号规范(合规性)
    新版本号为 6.5.28。在 Debian 的版本比较算法中,如果没有特殊的发行版需求,这是合法的。但请注意,Debian 官方规范通常建议在上游版本号之后加上 Debian 修订号(如 -1),即 6.5.28-1。如果这是 deepin 内部特定的版本规范则无需修改,但需确保与 debian/control 和项目整体的版本管理策略保持一致。

2. 项目维护建议(关联代码审查)

虽然 diff 中没有展示具体的 C++/Qt 代码,但 changelog 中提到了关键的修复逻辑:"Fix ZIP multi-volume compression not working after pzip plugin was introduced"。基于此背景,我提供以下代码层面的审查建议,请对照修改对应的业务代码进行自查:

  • 逻辑与状态管理
    引入 pzip 插件后导致原生的 ZIP 多卷压缩失效,通常是因为插件注册机制覆盖了默认的压缩处理器,或者在多卷分卷逻辑的判断分支中被错误地路由到了 pzip 插件。

    • 建议:检查插件工厂或路由分发代码,确保 pzip 插件的优先级和匹配条件(如文件头 Magic Number 或扩展名)不会拦截普通的 ZIP 多卷压缩请求。
  • 代码安全
    处理多卷压缩(分卷压缩/解压)是缓冲区溢出和目录穿越漏洞的高发区。

    • 建议:在修复多卷逻辑时,务必对跨卷读取时的缓冲区边界进行严格校验;同时在解压时,防范因恶意构造的压缩包导致的路径穿越(如 ../../../etc/passwd)。
  • 代码性能
    多卷压缩涉及频繁的 I/O 切换和文件描述符操作。

    • 建议:确保在切换分卷文件时,没有频繁的内存分配/释放操作,避免在处理大文件时产生性能瓶颈。同时注意跨卷时的缓冲区应复用而非重新分配。

总结

本次 debian/changelog 的修改格式基本规范,但必须修正 2026 年的错误时间戳。建议使用 dch 工具管理 changelog 以规避此类低级错误。同时,请结合上述业务逻辑建议,对修复 ZIP 多卷压缩的实际代码进行严格的自测,确保插件隔离性和 I/O 安全性。

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 14, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.28
  • Tag SHA: 818887d169af5c3e01df90b2d4005daf15aa6f5d
  • Commit SHA: 85cd5eb85c9f4af55eccdd10b1d4a36230e5f769
  • Tag Message:
    Release deepin-compressor 6.5.28
    
    
  • Tagger:
    • Name: dengzhongyuan365-dev
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants