fix(nav): default project-selector to Projects tab on Project lens by manishdixitlfx · Pull Request #717 · linuxfoundation/lfx-self-serve

manishdixitlfx · 2026-05-16T04:33:07Z

Summary

For hybrid personas (users with both board and project roles), the Project lens button serves as a merged entry that shows both Foundations and Projects in the picker. The active tab defaulted to "All", which sorts foundations first per the load-priority comment — so opening the picker on Project lens led with a Foundation row (e.g. AAIF tagged "Executive Director") even though the user just clicked Project.

Fix

Compute a defaultTab signal that returns 'projects' when lens === 'project', 'all' otherwise. Set activeTab to defaultTab() on both panel show and panel hide:

private readonly defaultTab: Signal<SelectorTab> = computed(() =>
  this.lens() === 'project' ? 'projects' : 'all'
);

protected onPopoverShow(): void {
  this.isPanelOpen.set(true);
  this.activeTab.set(this.defaultTab());
}

protected onPopoverHide(): void {
  this.isPanelOpen.set(false);
  this.activeTab.set(this.defaultTab());
  ...
}

Tabs only render in hybrid mode (@if (hybridMode())), so non-hybrid users (project-only or board-only personas) see no UX change.

Test plan

Verified in Chrome on localhost:4200 with a hybrid persona (ED + Board Member + Contributor):

Click Project lens → URL updates to /project/overview?project=...
Click the project-selector chip → picker opens
Active tab is Projects (not All)
First result is a Project, not a Foundation
Tabs still let user switch to "Foundations" or "All" inside the picker
yarn format / yarn lint / yarn build all clean

Out of scope

The deeper question of whether setLens('project') should also auto-default currentPersona to a project-scoped persona (maintainer → contributor) is intentionally left out — that's a separate behavior change in LensService / PersonaService and warrants its own discussion. The constants PROJECT_SCOPED_PERSONA_PRIORITY already exist for that follow-up.

🤖 Generated with Claude Code

For hybrid personas (users with both board and project roles), the Project lens button serves as a merged entry that shows both Foundations and Projects in the picker. The active tab defaulted to "All", which sorts foundations first per the load-priority comment — so opening the picker on Project lens led with a Foundation row (e.g. AAIF tagged Executive Director) even though the user just clicked Project. Fix: compute a defaultTab signal that returns 'projects' when the lens is 'project' and 'all' otherwise, then set activeTab to defaultTab() on both panel show and panel hide. Users on Project lens now see Projects first; they can still switch to Foundations or All inside the picker. Tabs only render in hybrid mode, so non-hybrid users (project-only or board-only personas) see no UX change. Verified in Chrome on localhost: Project lens entry opens the picker with the Projects tab active and EnerGNN (the active project) as the first result. Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

coderabbitai · 2026-05-16T04:33:21Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7f5ffc4-113b-480d-8324-849dae892d42

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

ProjectSelectorComponent now computes a default tab based on the current lens input, defaulting to 'projects' for the project lens and 'all' otherwise. The popover open handler sets the active tab to this computed default, and the hide handler resets it to the same default instead of hard-coding 'all'.

Changes

Default tab logic based on lens

Layer / File(s)	Summary
Default tab selection and popover behavior `apps/lfx-one/src/app/shared/components/project-selector/project-selector.component.ts`	Adds computed `defaultTab` signal that selects the initial tab based on `lens` input (`'projects'` for project lens; otherwise `'all'`). Updates popover open handler to set `activeTab` to `defaultTab` and hide handler to reset `activeTab` back to `defaultTab` instead of hard-coded `'all'`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: setting the project-selector to default to the Projects tab when the Project lens is active.
Description check	✅ Passed	The description comprehensively explains the problem, the fix, the scope, and includes test verification—all closely related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/LFXV2-1847-project-lens-tab-default

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Adjusts the project selector popover behavior for hybrid personas so that when the user is in the Project lens, the selector defaults to the Projects tab (instead of All), ensuring project results are shown first.

Changes:

Add a defaultTab computed signal that maps lens === 'project' to 'projects', otherwise 'all'.
Reset activeTab to defaultTab() when the popover opens and when it closes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

For hybrid personas (board + project roles), the Project lens button is the merged entry — the Foundation button is hidden. The default-picker used PROJECT_SCOPED_PERSONA_PRIORITY which skips board-member entirely, so a user with board roles on TLF / AAIF / TPG-IT was being defaulted to whichever contributor project the server returned first (e.g. LFX One via 4368 contributions), ignoring their highest-authority role. Fix: - pickItemByPersonaPriority now uses the full PERSONA_PRIORITY (executive-director, board-member, maintainer, contributor) when the user is a hybrid persona, so board roles aren't skipped. - Among same-persona matches, prefer the root-most project (one whose parentProjectUid is outside the user's accessible item set). That way The Linux Foundation beats AAIF when both carry board-member, since AAIF's parent is TLF (in the user's set) and TLF's parent is the org meta uid (outside the set). - getPriorityUid uses the same picker so the priority signal stays in sync with the default-selection signal. Foundation lens is unchanged (still uses BOARD_SCOPED_PERSONA_PRIORITY). Non-hybrid project-only users are unchanged (still PROJECT_SCOPED_PERSONA_PRIORITY). Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

dealako

Hey Manish! Nice, focused PR — two well-scoped fixes that tighten up the hybrid-persona experience without disturbing non-hybrid or foundation-only users. The commit 1 tab-default change is clean and the rationale is obvious. Commit 2 is the meatier one and overall correct, though I have one clarification question on its stated behaviour before you land it.

0 blocking · 3 minor · 2 nit

Decision: Approved with minor comments — the clarification in commit 2 is worth confirming before merge, but nothing rises to blocking.

AI bot reconciliation

CodeRabbit: PR is in draft, skipped — no findings to reconcile.
Copilot: summarised commit 1's tab-default change only; did not surface commit 2 or any findings. My comments extend coverage to commit 2 with no conflicts.
Cursor Bot: no comments on this PR.

Revision tracking: first human review round.

[minor] PR description / test plan

The title and description cover commit 1 (tab default) only. Commit 2 makes a substantive change to the default-selection algorithm — PROJECT_SCOPED_PERSONA_PRIORITY → full PERSONA_PRIORITY for hybrid + root-most tiebreaker — with no corresponding test-plan entry. Recommend adding a bullet like: "Hybrid user with board roles on multiple items and contributor activity elsewhere — verify default selection lands on a board-role project, not the top contributor result."

dealako · 2026-05-16T06:09:44Z

+  /**
+   * Project lens for a hybrid persona is the merged entry (Foundation button is hidden); use the
+   * full priority so the user's highest-authority role wins instead of falling through to contributor.
+   */
+  private getPickerPriority(lens: NavLens): readonly PersonaType[] {
+    if (lens === 'foundation') return BOARD_SCOPED_PERSONA_PRIORITY;
+    return this.lensService.isHybridPersona() ? PERSONA_PRIORITY : PROJECT_SCOPED_PERSONA_PRIORITY;
+  }
+
+  /** Prefer items where the user holds an in-priority persona; among same-persona matches prefer root-most (parent outside the user's accessible set). Falls back to the first item. */
  private pickItemByPersonaPriority(items: LensItem[], priority: readonly PersonaType[]): LensItem {
    const personaProjects = this.personaService.personaProjects();
+    const itemUids = new Set(items.map((i) => i.uid));
+    const enrichedByUid = new Map(this.personaService.detectedProjects().map((p) => [p.projectUid, p]));
    for (const persona of priority) {
      const projects = personaProjects[persona] ?? [];
+      const matches: { item: LensItem; isRoot: boolean }[] = [];
      for (const project of projects) {
-        const match = items.find((item) => item.uid === project.projectUid);
-        if (match) return match;
+        const item = items.find((i) => i.uid === project.projectUid);
+        if (!item) continue;
+        const parentUid = enrichedByUid.get(item.uid)?.parentProjectUid;
+        const isRoot = !parentUid || !itemUids.has(parentUid);
+        matches.push({ item, isRoot });
      }
+      if (matches.length === 0) continue;
+      // Prefer a root-level match (no in-set parent) so e.g. The Linux Foundation beats AAIF when both carry board-member.
+      return (matches.find((m) => m.isRoot) ?? matches[0]).item;
    }
    return items[0];
  }


[minor] Clarification: does the TLF-beats-AAIF root-most scenario actually reach this code for hybrid project-lens users?

The commit message (and the comment at line 207) describe preferring The Linux Foundation over AAIF when both carry board-member, because AAIF's parent is TLF (in the user's set) and TLF's parent is the org meta UID (outside the set).

But applyVisibilityFilters (lines 391-396) strips isFoundation items from project-lens results whenever availableLenses contains 'foundation' — which it does for every hybrid user, because LensService.getAllowedLensIds() adds 'foundation' whenever hasBoardRole() is true (lens.service.ts:73-85). This was an explicit choice in PR #713 (fix(nav): restore availableLenses to full allowed set … keep filtering foundations out of the project lens for hybrid users).

So for the hybrid project-lens case pickItemByPersonaPriority sees a foundation-free items array: TLF is never present, and the described tiebreak between TLF and AAIF can't materialise on this lens. The core fix — board-member matches rank ahead of contributor matches — is still meaningful and correct. But the root-most preference seems to apply on the foundation lens (where items aren't filtered) and to non-hybrid project-only users, not the scenario described.

Could you confirm whether I'm reading the filter interaction correctly, or point to where TLF does appear in the project-lens item set for hybrid users? Happy to be corrected if there's a data path I'm missing.

dealako · 2026-05-16T06:09:44Z

+        matches.push({ item, isRoot });
      }
+      if (matches.length === 0) continue;
+      // Prefer a root-level match (no in-set parent) so e.g. The Linux Foundation beats AAIF when both carry board-member.


[minor] Comment wording: "item set" implies the user's full accessible set, not the current page

itemUids is built from items.map(i => i.uid) — the items in the current page only. In a paginated context an entry could appear root-most simply because its parent hasn't been loaded yet. Suggest: "parent outside the current page's loaded items" (or similar) to make the scope clear.

dealako · 2026-05-16T06:09:44Z

  protected readonly activeTab = signal<SelectorTab>('all');
  protected readonly selectorTabs: readonly SelectorTab[] = ['all', 'foundations', 'projects'];
+  // Project lens defaults the picker to its matching tab so projects rank first; foundation lens uses 'all' (the only other hybrid case, where users explicitly went to a board context).
+  private readonly defaultTab: Signal<SelectorTab> = computed(() => (this.lens() === 'project' ? 'projects' : 'all'));


[nit] Visibility grouping

private readonly defaultTab sits between the protected readonly fields above and below it. Per the component-organization rule the structure order groups fields by visibility. Cosmetic — easy to move if you're already in the file.

dealako · 2026-05-16T06:09:44Z


  protected readonly activeTab = signal<SelectorTab>('all');
  protected readonly selectorTabs: readonly SelectorTab[] = ['all', 'foundations', 'projects'];
+  // Project lens defaults the picker to its matching tab so projects rank first; foundation lens uses 'all' (the only other hybrid case, where users explicitly went to a board context).


[nit] Long inline comment (~180 chars)

The parenthetical // … the only other hybrid case, where users explicitly went to a board context pushes this past comfortable reading width. Could trim or wrap — non-blocking.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+        const item = items.find((i) => i.uid === project.projectUid);
+        if (!item) continue;
+        const parentUid = enrichedByUid.get(item.uid)?.parentProjectUid;
+        const isRoot = !parentUid || !itemUids.has(parentUid);
+        matches.push({ item, isRoot });


      for (const project of projects) {
-        const match = items.find((item) => item.uid === project.projectUid);
-        if (match) return match;
+        const item = items.find((i) => i.uid === project.projectUid);


Copilot AI review requested due to automatic review settings May 16, 2026 04:33

manishdixitlfx requested a review from a team as a code owner May 16, 2026 04:33

Copilot started reviewing on behalf of manishdixitlfx May 16, 2026 04:33 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

manishdixitlfx marked this pull request as draft May 16, 2026 04:46

dealako approved these changes May 16, 2026

View reviewed changes

Merge branch 'main' into feat/LFXV2-1847-project-lens-tab-default

f43c504

Copilot AI review requested due to automatic review settings May 18, 2026 15:28

Copilot started reviewing on behalf of dealako May 18, 2026 15:28 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(nav): default project-selector to Projects tab on Project lens#717

fix(nav): default project-selector to Projects tab on Project lens#717
manishdixitlfx wants to merge 3 commits into
mainfrom
feat/LFXV2-1847-project-lens-tab-default

manishdixitlfx commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

dealako left a comment

Uh oh!

dealako May 16, 2026

Uh oh!

dealako May 16, 2026

Uh oh!

dealako May 16, 2026

Uh oh!

dealako May 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

manishdixitlfx commented May 16, 2026

Summary

Fix

Test plan

Out of scope

Uh oh!

coderabbitai Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

dealako left a comment

Choose a reason for hiding this comment

Uh oh!

dealako May 16, 2026

Choose a reason for hiding this comment

Uh oh!

dealako May 16, 2026

Choose a reason for hiding this comment

Uh oh!

dealako May 16, 2026

Choose a reason for hiding this comment

Uh oh!

dealako May 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented May 16, 2026 •

edited

Loading