Improve large balance amount display#41
Open
crossagent-production-app[bot] wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Delivery Evidence SummaryChange:
Objective Evidence:
Visual Evidence:
Reviewer:
Risks / Not Covered:
Generated at: 2026-05-25T19:41:22Z |
Open
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #40
Summary
Verification
npm test -- --runTestsByPath src/__tests__/utils/text.test.ts --runInBandE2E_BASE_URL=http://localhost:3210 ./node_modules/.bin/playwright test tmp/task_2ce70c44022b4334/account-balance-format.e2e.spec.ts --reporter=line./node_modules/.bin/playwright test tmp/task_2ce70c44022b4334/pr-evidence-render.e2e.spec.ts --reporter=lineDelivery Evidence Summary
Change:
Large balance/value fields now render in compact human-readable units, for example
12.0648 Million,2.5597 Million, and9.5051 Millionon the reported account card, while small and ordinary values keep readable decimal precision.Objective Evidence:
npm test -- --runTestsByPath src/__tests__/utils/text.test.ts --runInBand(29 tests passed).E2E_BASE_URL=http://localhost:3210 ./node_modules/.bin/playwright test tmp/task_2ce70c44022b4334/account-balance-format.e2e.spec.ts --reporter=line(1 Playwright test passed)../node_modules/.bin/playwright test tmp/task_2ce70c44022b4334/pr-evidence-render.e2e.spec.ts --reporter=line(1 Playwright test passed).Visual Evidence:
Source Screenshot Match: matched the reported
/sub/account/49VYuGkjdmZprGpb4jU313RdSffxSVHixojzmafdFYGpVYXbpage and same balance card/table section with anchorsAccount,Total Balance,Transferrable,Locked,Vested,Reserved, and theExtrinsicstab. Live API data now returns a non-zero Vested value, so that field differs from the first source screenshot but the matched product surface is the same.Reviewer:
@repo Intake Reviewer
Risks / Not Covered:
npm run prettier -- --check ...invokes the repository's app-wide Prettier script and still fails on existing formatting drift across many untouched files; this PR did not reformat the whole frontend.