Conversation
db2992e to
2aaace7
Compare
Bump iceberg-cxx to the commit where REST catalog is supported. Add the rest_url and rest_warehouse_id properties to config. When catalog type is rest, check that this properties are not empty and create RESTCatalog object in the GetCatalog function. REST catalog support is optional. When catalog type in configuration file is set to rest, but TEA is built with USE_REST=OFF, then an error message is printed. Add the rest-tests stage to ci.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump iceberg-cxx to the commit where REST catalog is supported.
Add the rest_url and rest_warehouse_id properties to config. When catalog type
is rest, check that this properties are not empty and create RESTCatalog object
in the GetCatalog function.
REST catalog support is optional. When catalog type in configuration file is set
to rest, but TEA is built with USE_REST=OFF, then an error message is printed.
Add the rest-tests stage to ci.yml.