Skip to content

Feature/unique sorted faces#19

Open
Matties1994 wants to merge 8 commits into
liusida:mainfrom
Matties1994:feature/unique-sorted-faces
Open

Feature/unique sorted faces#19
Matties1994 wants to merge 8 commits into
liusida:mainfrom
Matties1994:feature/unique-sorted-faces

Conversation

@Matties1994
Copy link
Copy Markdown

No description provided.

Matties1994 and others added 8 commits June 29, 2025 08:07
added filter
- Added Intersection over Union (IoU) based duplicate face detection and filtering.
- Ensured faces can be sorted from largest to smallest after duplicate removal.
- Corrected a minor bug in image upscaling parameter order.
- The `_detect_and_crop` method now also returns raw bounding boxes used for IoU calculations.
- Added helper methods `_calculate_iou` and `_filter_duplicate_detections`.
- Unable to run tests due to sandbox environment disk space limitations during torch installation.
- Added a check at the beginning of `auto_crop_faces` to verify if the input `image` is `None`.
- If the image is `None`, an error message is printed, and the node returns a dummy tensor and `None` for crop data to prevent the `AttributeError: 'NoneType' object has no attribute 'shape'`.
- This makes the node more robust to missing inputs in a ComfyUI workflow.
@liusida
Copy link
Copy Markdown
Owner

liusida commented Jul 13, 2025

Hi, thanks for your contribution!

I noticed the latest two commits were made by a bot account. Could you clarify why the bot was used for these updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants