Skip to content

Harden audio wave dispatcher default host#6141

Open
osurmach wants to merge 1 commit into
livekit:mainfrom
osurmach:olga/security-and-devex-review
Open

Harden audio wave dispatcher default host#6141
osurmach wants to merge 1 commit into
livekit:mainfrom
osurmach:olga/security-and-devex-review

Conversation

@osurmach

Copy link
Copy Markdown

Summary

Updates the audio-wave avatar example dispatcher to bind to localhost by default instead of all interfaces.

Why

The dispatcher exposes a /launch endpoint that accepts LiveKit room connection data and starts local worker subprocesses. For an example intended to run locally, binding to localhost is a safer default and avoids unintentionally exposing the endpoint on the local network.

This is a defense-in-depth change for the example default. The subprocess call uses an argv list, and this change is not intended to address command injection.

Changes

  • Default dispatcher host changed to 127.0.0.1
  • External binding remains possible through explicit configuration
  • Added/updated comments or documentation to explain when to use 0.0.0.0

Testing

  • Ran the audio-wave avatar example locally with the default host
  • Verified the dispatcher still starts and /launch works from localhost

@osurmach osurmach requested a review from a team as a code owner June 17, 2026 17:05
@CLAassistant

CLAassistant commented Jun 17, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@osurmach osurmach force-pushed the olga/security-and-devex-review branch 3 times, most recently from 9e856d1 to e249761 Compare June 17, 2026 17:22
@osurmach osurmach force-pushed the olga/security-and-devex-review branch from e249761 to 952f3eb Compare June 17, 2026 17:32

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants