Harden audio wave dispatcher default host#6141
Open
osurmach wants to merge 1 commit into
Open
Conversation
9e856d1 to
e249761
Compare
e249761 to
952f3eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the audio-wave avatar example dispatcher to bind to localhost by default instead of all interfaces.
Why
The dispatcher exposes a
/launchendpoint that accepts LiveKit room connection data and starts local worker subprocesses. For an example intended to run locally, binding to localhost is a safer default and avoids unintentionally exposing the endpoint on the local network.This is a defense-in-depth change for the example default. The subprocess call uses an argv list, and this change is not intended to address command injection.
Changes
127.0.0.10.0.0.0Testing
/launchworks from localhost