Skip to content

add ringingTimeput field to SIP inbound create api #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-hamdananwar merged 4 commits into from
Apr 7, 2026
Merged

add ringingTimeput field to SIP inbound create api #645

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14a4409
add ringingTimeput field to sin inbound create api
s-hamdananwar Apr 7, 2026
9ce836c
use number instead of Duration in opts
s-hamdananwar Apr 7, 2026
9c268bc
format fix
s-hamdananwar Apr 7, 2026
51cf670
Create purple-donkeys-tap.md
lukasIO Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/livekit-server-sdk/src/SipClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
RoomConfiguration,
SIPHeaderOptions,
} from '@livekit/protocol';
import {

Check warning on line 11 in packages/livekit-server-sdk/src/SipClient.ts

View workflow job for this annotation

GitHub Actions / Formatting 

Imports "SIPMediaEncryption" and "SIPOutboundConfig" are only used as type
CreateSIPDispatchRuleRequest,
CreateSIPInboundTrunkRequest,
CreateSIPOutboundTrunkRequest,
Expand Down Expand Up @@ -81,6 +81,8 @@
includeHeaders?: SIPHeaderOptions;
krispEnabled?: boolean;
mediaEncryption?: SIPMediaEncryption;
/** Maximum time for a call to ring in seconds. */
ringingTimeout?: number;
}
export interface CreateSipOutboundTrunkOptions {
metadata?: string;
Expand Down Expand Up @@ -314,6 +316,9 @@
includeHeaders: opts.includeHeaders,
krispEnabled: opts.krispEnabled,
mediaEncryption: opts.mediaEncryption,
ringingTimeout: opts.ringingTimeout
? new Duration({ seconds: BigInt(opts.ringingTimeout) })
: undefined,
}),
}).toJson();

Expand Down
Loading