-
Notifications
You must be signed in to change notification settings - Fork 114
Add userdata to audioframe constructor #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f20abdd
feat: add userdata to audioframe constructor
1egoman 518e541
Update livekit-rtc/livekit/rtc/audio_frame.py
1egoman 20fc6bc
fix: apply other suggestion and flx type error
1egoman 3a22df8
fix: remove extra colon
1egoman 5a4a383
fix: swap out pipe for typing.union
1egoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -33,6 +33,7 @@ def __init__( | |||||||
| sample_rate: int, | ||||||||
| num_channels: int, | ||||||||
| samples_per_channel: int, | ||||||||
| userdata: dict[str, Any] = {}, | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let's make it a kwarg |
||||||||
| ) -> None: | ||||||||
| """ | ||||||||
| Initialize an AudioFrame instance. | ||||||||
|
|
@@ -64,7 +65,7 @@ def __init__( | |||||||
| self._sample_rate = sample_rate | ||||||||
| self._num_channels = num_channels | ||||||||
| self._samples_per_channel = samples_per_channel | ||||||||
| self._userdata: dict[str, Any] = {} | ||||||||
| self._userdata: dict[str, Any] = userdata | ||||||||
|
|
||||||||
| @staticmethod | ||||||||
| def create(sample_rate: int, num_channels: int, samples_per_channel: int) -> "AudioFrame": | ||||||||
|
|
||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.