NCU Reader: Enable reading more generic nsight profiles#266
Merged
Conversation
michaelmckinsey1
added
the
status-work-in-progress
michaelmckinsey1
force-pushed
the
kripke-ncu
branch
from
6096905 to
721ded2
Compare
michaelmckinsey1
force-pushed
the
kripke-ncu
branch
from
721ded2 to
1af7fd2
Compare
michaelmckinsey1
changed the title
michaelmckinsey1
added
status-ready-for-review
slabasan
approved these changes
May 13, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We designed the reader originally with test cases from RAJAPerf. When I was running this on kripke data, I realized it needs functionality to support other apps.
This PR loosens the matching criteria, removing assumptions that helped us match RAJAPerf kernels specifically.
The functionality has now been tested for Kripke and Laghos profiles as well.